From: Jeff Dike <jdike@addtoit.com>
To: Blaisorblade <blaisorblade@yahoo.it>
Cc: user-mode-linux-devel@lists.sourceforge.net,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [uml-devel] Re: [PATCH 12/16] UML - Memory hotplug
Date: Fri, 24 Mar 2006 20:19:03 -0500 [thread overview]
Message-ID: <20060325011903.GC8117@ccure.user-mode-linux.org> (raw)
In-Reply-To: <200603250058.57700.blaisorblade@yahoo.it>
On Sat, Mar 25, 2006 at 12:58:57AM +0100, Blaisorblade wrote:
> > +int os_drop_memory(void *addr, int length)
> > +{
> > + int err;
> > +
> > + err = madvise(addr, length, MADV_REMOVE);
> > + if(err < 0)
> > + err = -errno;
>
> Jeff, did you mean the "return _0_" rather than "return err" below? It's
> incoherent with the existance of the "err" local.
>
> > + return 0;
> > +}
That's just a brain fart - will fix.
Jeff
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Dike <jdike@addtoit.com>
To: Blaisorblade <blaisorblade@yahoo.it>
Cc: user-mode-linux-devel@lists.sourceforge.net,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [uml-devel] Re: [PATCH 12/16] UML - Memory hotplug
Date: Fri, 24 Mar 2006 20:19:03 -0500 [thread overview]
Message-ID: <20060325011903.GC8117@ccure.user-mode-linux.org> (raw)
In-Reply-To: <200603250058.57700.blaisorblade@yahoo.it>
On Sat, Mar 25, 2006 at 12:58:57AM +0100, Blaisorblade wrote:
> > +int os_drop_memory(void *addr, int length)
> > +{
> > + int err;
> > +
> > + err = madvise(addr, length, MADV_REMOVE);
> > + if(err < 0)
> > + err = -errno;
>
> Jeff, did you mean the "return _0_" rather than "return err" below? It's
> incoherent with the existance of the "err" local.
>
> > + return 0;
> > +}
That's just a brain fart - will fix.
Jeff
next prev parent reply other threads:[~2006-03-25 1:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 18:14 [uml-devel] [PATCH 12/16] UML - Memory hotplug Jeff Dike
2006-03-24 18:14 ` Jeff Dike
2006-03-24 22:45 ` [uml-devel] " Andrew Morton
2006-03-24 22:45 ` Andrew Morton
2006-03-24 23:58 ` [uml-devel] " Blaisorblade
2006-03-24 23:58 ` Blaisorblade
2006-03-25 1:19 ` Jeff Dike [this message]
2006-03-25 1:19 ` Jeff Dike
2006-03-25 1:05 ` Jeff Dike
2006-03-25 1:05 ` Jeff Dike
2006-04-05 22:02 ` [uml-devel] " Daniel Phillips
2006-04-05 22:02 ` Daniel Phillips
2006-04-06 1:56 ` [uml-devel] " Jeff Dike
2006-04-06 1:56 ` Jeff Dike
2006-04-06 3:32 ` Andrew Morton
2006-04-06 3:32 ` Andrew Morton
2006-04-06 3:33 ` Andrew Morton
2006-04-06 3:33 ` Andrew Morton
2006-04-06 3:42 ` Daniel Phillips
2006-04-06 3:42 ` Daniel Phillips
2006-03-25 19:26 ` Jan Engelhardt
2006-03-25 19:26 ` Jan Engelhardt
2006-03-25 20:08 ` [uml-devel] " Jeff Dike
2006-03-25 20:08 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060325011903.GC8117@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=blaisorblade@yahoo.it \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.