From: "David S. Miller" <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: shemminger@osdl.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ip_route_input panic fix
Date: Mon, 17 Apr 2006 22:45:46 -0700 (PDT) [thread overview]
Message-ID: <20060417.224546.89269212.davem@davemloft.net> (raw)
In-Reply-To: <E1FVfxQ-0008Tf-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 18 Apr 2006 12:28:48 +1000
> Stephen Hemminger <shemminger@osdl.org> wrote:
> > + /* Bugfix: need to give ip_route_input enough of an IP header to not gag. */
> > + skb->nh.iph->protocol = IPPROTO_ICMP;
>
> Do we really need this? After all we can get completely bogus values
> coming in through the network too.
ip_mc_check() will return 1 if it happens to be IGMP, that's not
a good default for this netlink lookup case.
next prev parent reply other threads:[~2006-04-18 5:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 0:12 [PATCH] ip_route_input panic fix Stephen Hemminger
2006-04-18 2:28 ` Herbert Xu
2006-04-18 2:49 ` Stephen Hemminger
2006-04-18 2:54 ` Herbert Xu
2006-04-18 5:45 ` David S. Miller [this message]
2006-04-18 6:54 ` Herbert Xu
2006-04-18 21:54 ` David S. Miller
2006-04-18 22:08 ` Herbert Xu
2006-04-18 23:52 ` Alexey Kuznetsov
2006-04-19 0:17 ` Herbert Xu
2006-04-19 3:53 ` David S. Miller
2006-04-19 9:46 ` Alexey Kuznetsov
-- strict thread matches above, loose matches on Subject: below --
2006-04-19 0:59 Alexey Kuznetsov
2006-04-19 1:00 Alexey Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060417.224546.89269212.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.