From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: "David S. Miller" <davem@davemloft.net>
Cc: herbert@gondor.apana.org.au, shemminger@osdl.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ip_route_input panic fix
Date: Wed, 19 Apr 2006 13:46:59 +0400 [thread overview]
Message-ID: <20060419094659.GA16973@ms2.inr.ac.ru> (raw)
In-Reply-To: <20060418.205317.18564378.davem@davemloft.net>
Hello!
> ipmr_get_route() is the trouble maker. If ipmr_cache_find() cannot
> find an entry, it tries to use the netlink SKB to send out an ipv4
> packet, completely mangling it, via ipmr_cache_unresolved().
It just adds dummy IP header to tail of this skb. Nothing illegal.
The skb is not sent out, it is enqueued in an ARP-like queue and
the IP header is submitted to mroute_socket.
When user level mrouter resolves the route, ipmr_cache_resolve()
removes this, completes filling netlink attributes and sends it to netlink.
> Even worse it may even free the skb on us,
Oops, seems, this is a real bug... Need to think how to fix.
> or queue it to mroute_socket.
It is OK, it is the purpose.
> It is pure disaster, this entire code path.
Well, it may be buggy, but esentially there is nothing to simplify.
At least, I do not see.
Alexey
next prev parent reply other threads:[~2006-04-19 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 0:12 [PATCH] ip_route_input panic fix Stephen Hemminger
2006-04-18 2:28 ` Herbert Xu
2006-04-18 2:49 ` Stephen Hemminger
2006-04-18 2:54 ` Herbert Xu
2006-04-18 5:45 ` David S. Miller
2006-04-18 6:54 ` Herbert Xu
2006-04-18 21:54 ` David S. Miller
2006-04-18 22:08 ` Herbert Xu
2006-04-18 23:52 ` Alexey Kuznetsov
2006-04-19 0:17 ` Herbert Xu
2006-04-19 3:53 ` David S. Miller
2006-04-19 9:46 ` Alexey Kuznetsov [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-04-19 0:59 Alexey Kuznetsov
2006-04-19 1:00 Alexey Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060419094659.GA16973@ms2.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.