From: Christoph Hellwig <hch@infradead.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
Lee Revell <rlrevell@joe-job.com>,
Adrian McMenamin <adrian@mcmen.demon.co.uk>,
Paul Mundt <lethal@linux-sh.org>,
Alsa-devel <alsa-devel@lists.sourceforge.net>,
linux-sh <linuxsh-dev@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Re: [linuxsh-dev] [PATCH] ALSA driver for Yamaa AICA on Sega Dreamcast
Date: Tue, 18 Apr 2006 12:52:24 +0100 [thread overview]
Message-ID: <20060418115224.GA8591@infradead.org> (raw)
In-Reply-To: <s5hhd4r9ohh.wl%tiwai@suse.de>
On Tue, Apr 18, 2006 at 12:17:46PM +0200, Takashi Iwai wrote:
> Heh, the suggested line is what CondingStyle suggets -- the output of
> indent program. Yeah, but better to fix "bad programming" :)
indent only fixes indentation. Moving the if check to a different line
as the function call changes more than indentation so indent doesn't do it.
Yes, there's more to code codingstyle than just running indent :)
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
Lee Revell <rlrevell@joe-job.com>,
Adrian McMenamin <adrian@mcmen.demon.co.uk>,
Paul Mundt <lethal@linux-sh.org>,
Alsa-devel <alsa-devel@lists.sourceforge.net>,
linux-sh <linuxsh-dev@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Alsa-devel] Re: [linuxsh-dev] [PATCH] ALSA driver for Yamaa AICA on Sega Dreamcast
Date: Tue, 18 Apr 2006 12:52:24 +0100 [thread overview]
Message-ID: <20060418115224.GA8591@infradead.org> (raw)
In-Reply-To: <s5hhd4r9ohh.wl%tiwai@suse.de>
On Tue, Apr 18, 2006 at 12:17:46PM +0200, Takashi Iwai wrote:
> Heh, the suggested line is what CondingStyle suggets -- the output of
> indent program. Yeah, but better to fix "bad programming" :)
indent only fixes indentation. Moving the if check to a different line
as the function call changes more than indentation so indent doesn't do it.
Yes, there's more to code codingstyle than just running indent :)
next prev parent reply other threads:[~2006-04-18 11:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-17 0:13 [PATCH] ALSA driver for Yamaa AICA on Sega Dreamcast Adrian McMenamin
2006-04-17 1:29 ` Paul Mundt
2006-04-17 1:29 ` [linuxsh-dev] " Paul Mundt
2006-04-17 9:44 ` [Alsa-devel] " Adrian McMenamin
2006-04-17 9:52 ` Paul Mundt
2006-04-17 10:04 ` Paul Mundt
2006-04-17 11:51 ` [linuxsh-dev] " Adrian McMenamin
2006-04-17 20:40 ` Adrian McMenamin
2006-04-17 20:00 ` Adrian McMenamin
2006-04-17 20:00 ` [linuxsh-dev] " Adrian McMenamin
2006-04-17 21:47 ` [Alsa-devel] " Lee Revell
2006-04-17 22:05 ` Christoph Hellwig
2006-04-17 22:15 ` Lee Revell
2006-04-18 10:17 ` Takashi Iwai
2006-04-18 10:17 ` [Alsa-devel] " Takashi Iwai
2006-04-18 11:52 ` Christoph Hellwig [this message]
2006-04-18 11:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060418115224.GA8591@infradead.org \
--to=hch@infradead.org \
--cc=adrian@mcmen.demon.co.uk \
--cc=alsa-devel@lists.sourceforge.net \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxsh-dev@lists.sourceforge.net \
--cc=rlrevell@joe-job.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.