* [PATCH] pp_aula/spc.h
@ 2006-05-02 22:32 Tom Kalus
2006-05-04 14:56 ` Christophe Varoqui
2006-05-04 21:38 ` Christophe Varoqui
0 siblings, 2 replies; 4+ messages in thread
From: Tom Kalus @ 2006-05-02 22:32 UTC (permalink / raw)
To: dm-devel
[-- Attachment #1: Type: text/plain, Size: 256 bytes --]
path_priority/pp_aula/spc.h
Isn't the inquiry_data.product_identifier 16 bytes long? or do I need a
later draft of SPC3... 21d - Feb 2005
Bug doesn't effect existing code, but it's still a bug.
Rest looks ok, so far as I can tell.
See attached patch.
[-- Attachment #2: spc3.h.patch --]
[-- Type: text/plain, Size: 774 bytes --]
diff --git a/path_priority/pp_alua/spc3.h b/path_priority/pp_alua/spc3.h
index 11f5dbd..bddbbdd 100644
--- a/path_priority/pp_alua/spc3.h
+++ b/path_priority/pp_alua/spc3.h
@@ -148,10 +148,10 @@ struct inquiry_data {
/* ......x. = command queue support */
/* .......x = vs2 */
unsigned char vendor_identification[8];
- unsigned char product_identification[8];
+ unsigned char product_identification[16];
unsigned char product_revision[4];
unsigned char vendor_specific[20];
- unsigned char b48; /* xxxx.... = reserved */
+ unsigned char b56; /* xxxx.... = reserved */
/* ....xx.. = clocking */
/* ......x. = qas */
/* .......x = ius */
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pp_aula/spc.h
2006-05-02 22:32 [PATCH] pp_aula/spc.h Tom Kalus
@ 2006-05-04 14:56 ` Christophe Varoqui
2006-05-04 15:20 ` Stefan Bader
2006-05-04 21:38 ` Christophe Varoqui
1 sibling, 1 reply; 4+ messages in thread
From: Christophe Varoqui @ 2006-05-04 14:56 UTC (permalink / raw)
To: stefan.bader; +Cc: device-mapper development
On Tue, May 02, 2006 at 03:32:02PM -0700, Tom Kalus wrote:
> path_priority/pp_aula/spc.h
>
> Isn't the inquiry_data.product_identifier 16 bytes long? or do I need a
> later draft of SPC3... 21d - Feb 2005
> Bug doesn't effect existing code, but it's still a bug.
> Rest looks ok, so far as I can tell.
>
> See attached patch.
>
>
> diff --git a/path_priority/pp_alua/spc3.h b/path_priority/pp_alua/spc3.h
> index 11f5dbd..bddbbdd 100644
> --- a/path_priority/pp_alua/spc3.h
> +++ b/path_priority/pp_alua/spc3.h
> @@ -148,10 +148,10 @@ struct inquiry_data {
> /* ......x. = command queue support */
> /* .......x = vs2 */
> unsigned char vendor_identification[8];
> - unsigned char product_identification[8];
> + unsigned char product_identification[16];
> unsigned char product_revision[4];
> unsigned char vendor_specific[20];
> - unsigned char b48; /* xxxx.... = reserved */
> + unsigned char b56; /* xxxx.... = reserved */
> /* ....xx.. = clocking */
> /* ......x. = qas */
> /* .......x = ius */
Stefan,
Can you you ack this one ?
Regards,
cvaroqui
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pp_aula/spc.h
2006-05-04 14:56 ` Christophe Varoqui
@ 2006-05-04 15:20 ` Stefan Bader
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Bader @ 2006-05-04 15:20 UTC (permalink / raw)
To: christophe.varoqui; +Cc: device-mapper development
The draft is good. This was/is a bug.
Mit freundlichem Gruß,
Stefan Bader
SW Linux on zSeries Development & Services
Stefan.Bader@de.ibm.com
----------------------------------------------------------------------------------
When all other means of communication fail, try words.
dm-devel-bounces@redhat.com wrote on 04.05.2006 16:56:45:
> On Tue, May 02, 2006 at 03:32:02PM -0700, Tom Kalus wrote:
> > path_priority/pp_aula/spc.h
> >
> > Isn't the inquiry_data.product_identifier 16 bytes long? or do I need
a
> > later draft of SPC3... 21d - Feb 2005
> > Bug doesn't effect existing code, but it's still a bug.
> > Rest looks ok, so far as I can tell.
> >
> > See attached patch.
> >
> >
>
> > diff --git a/path_priority/pp_alua/spc3.h
b/path_priority/pp_alua/spc3.h
> > index 11f5dbd..bddbbdd 100644
> > --- a/path_priority/pp_alua/spc3.h
> > +++ b/path_priority/pp_alua/spc3.h
> > @@ -148,10 +148,10 @@ struct inquiry_data {
> > /* ......x. = command queue support */
> > /* .......x = vs2 */
> > unsigned char vendor_identification[8];
> > - unsigned char product_identification[8];
> > + unsigned char product_identification[16];
> > unsigned char product_revision[4];
> > unsigned char vendor_specific[20];
> > - unsigned char b48; /* xxxx.... = reserved */
> > + unsigned char b56; /* xxxx.... = reserved */
> > /* ....xx.. = clocking */
> > /* ......x. = qas */
> > /* .......x = ius */
>
> Stefan,
>
> Can you you ack this one ?
>
> Regards,
> cvaroqui
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pp_aula/spc.h
2006-05-02 22:32 [PATCH] pp_aula/spc.h Tom Kalus
2006-05-04 14:56 ` Christophe Varoqui
@ 2006-05-04 21:38 ` Christophe Varoqui
1 sibling, 0 replies; 4+ messages in thread
From: Christophe Varoqui @ 2006-05-04 21:38 UTC (permalink / raw)
To: device-mapper development, tkalus
Le mardi 02 mai 2006 à 15:32 -0700, Tom Kalus a écrit :
> path_priority/pp_aula/spc.h
>
> Isn't the inquiry_data.product_identifier 16 bytes long? or do I need a
> later draft of SPC3... 21d - Feb 2005
> Bug doesn't effect existing code, but it's still a bug.
> Rest looks ok, so far as I can tell.
>
> See attached patch.
>
Merged.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-05-04 21:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-02 22:32 [PATCH] pp_aula/spc.h Tom Kalus
2006-05-04 14:56 ` Christophe Varoqui
2006-05-04 15:20 ` Stefan Bader
2006-05-04 21:38 ` Christophe Varoqui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.