Re: Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen

[Andi Kleen <ak@suse.de>]

On Monday 15 May 2006 19:17, Keir Fraser wrote:
> 
> On 15 May 2006, at 18:11, Ryan Harper wrote:
> 
> > When I looked at the x86_64 NUMA code, I noticed that SRAT parsing was
> > done by ACPI_NUMA (drivers/acpi/numa.c).  That code requires more ACPI
> > support than Xen currently has available.  Rather than pulling in all 
> > of
> > that ACPI, I chose to start with the i386 SRAT table parser which was
> > sufficient for both i386 and x86_64.  I would think that using the
> > modified i386 srat.c for parser gets the job done without bringing in
> > all of the support needed to compile drivers/acpi/numa.c in Xen.
> >
> > How about putting the two together: use the i386 SRAT parser and the
> > x86_64 srat.c for structures and initialization?
> 
> I guess it depends how cleanly it can be done. Can we use the x86/64 
> logic pretty much unmodified, but then pull in bits of the i386 parsing 
> code as functions that the x86/64 code calls rather than the full-blown 
> acpi routines it would usually call into? Or would it be possible to 
> pull in drivers/acpi/numa.c 

Yes it should be. numa parsing doesn't need the interpreter. It only
reads a few tables from memory. You could probably even recode it easily to just
call the callbacks in srat.c after looking for the tables in memory.

Bigger issue might be to make it fully 32bit clean. But probably just a few
long -> long long should be enough. 

One reason the i386 NUMA code is so ugly that limited 32bit address spaces 
and NUMA really don't love each other regarding ZONE_NORMAL handling.
The i386 code has some nasty hacks to work around that, like these
memory chunks. The result was always poor of course because NUMA
essentially didn't apply to any kernel objects.

I guess in Xen that might be a bit easier from simpler zone setup (?) 

Or if all fails limit NUMA again to 
64bit hypervisors where it is much cleaner (AFAIK except for the old x440 
and NUMAQ everything  x86 doing NUMA is 64bit  capable) 

-Andi