Re: Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen

[Ryan Harper <ryanh@us.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]

* Ryan Harper <ryanh@us.ibm.com> [2006-05-24 14:02]:
> * Andi Kleen <ak@suse.de> [2006-05-22 06:02]:
> > 
> > > The patch is function on 32-bit and 64-bit boxes and parse the SRAT
> > > table and fills out the node_data array.  I installed a simple
> > > keyhandler 'u' to dump the info to check that it was function after
> > > booting up.
> > 
> > It mostly looks reasonable. As Keir noted you seem to have a lot of unnecessary
> > changes (printk->DPRINTK, white space etc.)
> 
> Cleaned up.
> 
> > 
> > I would also suggest you keep the numa emulation. It's useful for debugging
> > so that developers without numa machines can reproduce numa issues.
> 
> Added numa emulation back in.  I've set it up such that if we fail to
> find a numa-node we fallback on to emulation of one node.  This allows
> the allocator code to not be filled with CONFIG_NUMA ifdefs as Keir
> wanted. 

This last patch didn't have a functional cpu_to_node/node_to_cpumask.
This patch fixes that up in addition to the previous cleanups.  Please
take a look.


-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@us.ibm.com

[-- Attachment #2: acpi_numa.tgz --]
[-- Type: application/x-gtar, Size: 9554 bytes --]

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel