From: Andi Kleen <ak@suse.de>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: Xen Devel <xen-devel@lists.xensource.com>, Ryan Grimm <grimm@us.ibm.com>
Subject: Re: Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen
Date: Mon, 22 May 2006 13:01:30 +0200 [thread overview]
Message-ID: <200605221301.30662.ak@suse.de> (raw)
In-Reply-To: <20060519210857.GR16876@us.ibm.com>
> The patch is function on 32-bit and 64-bit boxes and parse the SRAT
> table and fills out the node_data array. I installed a simple
> keyhandler 'u' to dump the info to check that it was function after
> booting up.
It mostly looks reasonable. As Keir noted you seem to have a lot of unnecessary
changes (printk->DPRINTK, white space etc.)
I would also suggest you keep the numa emulation. It's useful for debugging
so that developers without numa machines can reproduce numa issues.
-Andi
next prev parent reply other threads:[~2006-05-22 11:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-01 21:56 [PATCH 1/6] xen: Add NUMA support to Xen Ryan Harper
2006-05-02 14:15 ` Keir Fraser
2006-05-02 14:39 ` Ryan Harper
2006-05-12 15:12 ` [PATCH 1/6][RESEND] " Ryan Harper
2006-05-13 9:07 ` Keir Fraser
2006-05-15 16:27 ` Andi Kleen
2006-05-15 16:54 ` Keir Fraser
2006-05-15 17:11 ` Ryan Harper
2006-05-15 17:17 ` Keir Fraser
2006-05-15 17:23 ` Keir Fraser
2006-05-15 17:25 ` Andi Kleen
2006-05-15 17:27 ` Ryan Harper
2006-05-15 17:34 ` Keir Fraser
2006-05-15 20:32 ` Ryan Harper
2006-05-15 20:46 ` Andi Kleen
2006-05-16 7:49 ` Keir Fraser
2006-05-16 12:57 ` Andi Kleen
2006-05-16 13:03 ` Keir Fraser
2006-05-19 21:08 ` Ryan Harper
2006-05-20 8:50 ` Keir Fraser
2006-05-22 11:01 ` Andi Kleen [this message]
2006-05-24 19:02 ` Ryan Harper
2006-05-31 18:06 ` Ryan Harper
2006-06-02 15:55 ` Ryan Harper
2006-05-17 17:21 ` Ryan Harper
2006-05-17 18:07 ` Andi Kleen
2006-05-18 15:30 ` Ryan Harper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200605221301.30662.ak@suse.de \
--to=ak@suse.de \
--cc=grimm@us.ibm.com \
--cc=ryanh@us.ibm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.