[lm-sensors] [PATCH] hwmon w83792d add data lock to all store

[lm-sensors] [PATCH] hwmon w83792d add data lock to all store

[Yuan Mu]

Hi Jean,
I add the lock to all store functions in this patch, please can you check?
Thanks.

-- 
Best Regards
Yuan Mu


=============================================The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such  a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email irrelevant to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: hwmon-w83792d-add-lock.patch
Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060531/ccca7067/hwmon-w83792d-add-lock.pl

[lm-sensors] [PATCH] hwmon w83792d add data lock to all store

[Jean Delvare]

Hi Yuan,

> I add the lock to all store functions in this patch, please can
> you check?

It's OK except in store_pwmenable where you would leave with the lock
held on incorrect input value.

Your patch also lacked your signed-off-by line, and a proper summary...

-- 
Jean Delvare

[lm-sensors] [PATCH] hwmon w83792d add data lock to all store

[Yuan Mu]

Jean Delvare wrote:
> Hi Yuan,
> 
>> I add the lock to all store functions in this patch, please can
>> you check?
> 
> It's OK except in store_pwmenable where you would leave with the lock
> held on incorrect input value.
> 
> Your patch also lacked your signed-off-by line, and a proper summary...
> 

Sorry, maybe i heat my head too heavily last time :(
Can you check this one, thanks :)
-- 
Best Regards
Yuan Mu


=============================================The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such  a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email irrelevant to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: hwmon-w83792d-add-data-lock.patch
Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060601/5c2683ae/attachment.pl 

[lm-sensors] [PATCH] hwmon w83792d add data lock to all store

[Jean Delvare]

Hi Yuan,

> > > I add the lock to all store functions in this patch, please can
> > > you check?
> > 
> > It's OK except in store_pwmenable where you would leave with the lock
> > held on incorrect input value.
> > 
> > Your patch also lacked your signed-off-by line, and a proper summary...
> 
> Sorry, maybe i heat my head too heavily last time :(
> Can you check this one, thanks :)

No problem. I applied it with just one fix:

>  	default:
> -		return -EINVAL;
> +		break;
>  	}

This made the default case pretty useless so I dropped it altogether.

Thanks,
-- 
Jean Delvare