From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix for configure on x86_64 (Was: Re: [patch] Fix for building correct code on i386-pc (CVS-HEAD))
Date: Thu, 1 Jun 2006 17:39:13 +0200 [thread overview]
Message-ID: <200606011739.13486.okuji@enbug.org> (raw)
In-Reply-To: <87bqtdykn0.wl%jeroen@vrijschrift.org>
On Wednesday 31 May 2006 23:00, Jeroen Dekkers wrote:
> It's actually a necessary feature for GRUB on amd64. On amd64 you have
> 64-bit executables but GRUB will run in 32-bit mode.
>
> When trying to compile on amd64 I already ran into some problems
> related to that. First of all on amd64 all binaries are run in 64-bit
> mode, so the host CFLAGS variable shouldn't have -m32. Secondly LIBS
> is for the host only and shouldn't be defined when running target
> tests. As last we set CFLAGS, CC, etc. to the TARGET_*, then we run
> some checks and change the TARGET_* flags without updating CC, CFLAGS,
> etc to the new version.
>
> The attached patch should fix those problems. I've tested it on i386-pc
> and x86_64.
It looks good. Please check it in.
Thanks,
Okuji
next prev parent reply other threads:[~2006-06-01 15:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-30 21:08 [patch] Fix for building correct code on i386-pc (CVS-HEAD) Vesa Jääskeläinen
2006-05-30 21:15 ` Hollis Blanchard
2006-05-31 3:59 ` Harley D. Eades III
2006-05-30 22:00 ` Hollis Blanchard
2006-05-31 0:31 ` Yoshinori K. Okuji
2006-05-31 21:00 ` [PATCH] Fix for configure on x86_64 (Was: Re: [patch] Fix for building correct code on i386-pc (CVS-HEAD)) Jeroen Dekkers
2006-06-01 15:39 ` Yoshinori K. Okuji [this message]
2006-06-07 11:16 ` [PATCH] Another fix for x86_64 Jeroen Dekkers
2006-06-07 15:55 ` Marco Gerards
2006-05-30 22:10 ` [patch] Fix for building correct code on i386-pc (CVS-HEAD) Marco Gerards
2006-05-31 0:28 ` Yoshinori K. Okuji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606011739.13486.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.