From: hde@gnu.org (Harley D. Eades III)
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [patch] Fix for building correct code on i386-pc (CVS-HEAD)
Date: 30 May 2006 22:59:37 -0500 [thread overview]
Message-ID: <86r72aetee.fsf@baz.foobar-qux.org> (raw)
In-Reply-To: <1149023752.7177.86.camel@basalt.austin.ibm.com>
Hollis Blanchard <hollis@penguinppc.org> writes:
> On Wed, 2006-05-31 at 00:08 +0300, Vesa Jääskeläinen wrote:
> > Attached patch fixes problems for compiling correct code on i386-pc...
> > other platforms needs to be modified similarly too...
>
> I'm confused by this; could you explain? If _TARGET_CFLAGS is used for
> everything to be run on the target, perhaps we should just rename
> _CFLAGS to _TARGET_CFLAGS.
>
> Also, in the future, could you please supply best-guess code for other
> architectures? It's ok if you don't know, but in this case it seems it
> would be easy enough to duplicate your i386-pc.mk changes for the
> other .mk files.
I am also confused. Is this keeping to the changes presented by
Okuji? I don't think it is best to move from CFLAGS to something
different, this would make it odd when porting to other OS, it also
seems off convention.
Okuji's post:
http://lists.gnu.org/archive/html/grub-devel/2006-05/msg00106.html
Cheers
Harley
next prev parent reply other threads:[~2006-05-30 21:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-30 21:08 [patch] Fix for building correct code on i386-pc (CVS-HEAD) Vesa Jääskeläinen
2006-05-30 21:15 ` Hollis Blanchard
2006-05-31 3:59 ` Harley D. Eades III [this message]
2006-05-30 22:00 ` Hollis Blanchard
2006-05-31 0:31 ` Yoshinori K. Okuji
2006-05-31 21:00 ` [PATCH] Fix for configure on x86_64 (Was: Re: [patch] Fix for building correct code on i386-pc (CVS-HEAD)) Jeroen Dekkers
2006-06-01 15:39 ` Yoshinori K. Okuji
2006-06-07 11:16 ` [PATCH] Another fix for x86_64 Jeroen Dekkers
2006-06-07 15:55 ` Marco Gerards
2006-05-30 22:10 ` [patch] Fix for building correct code on i386-pc (CVS-HEAD) Marco Gerards
2006-05-31 0:28 ` Yoshinori K. Okuji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r72aetee.fsf@baz.foobar-qux.org \
--to=hde@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.