[PATCH] m68k: bogus constraints in signal.h

[PATCH] m68k: bogus constraints in signal.h

[Al Viro]

bfset and friends need "o", not "m" - they don't work with autodecrement
memory arguments.  bitops.h had it fixed, signal.h hadn't...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

---

 include/asm-m68k/signal.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

904a77fc8bfa159204cc895d672096e5d3a5a46e
diff --git a/include/asm-m68k/signal.h b/include/asm-m68k/signal.h
index b7b7ea2..f645162 100644
--- a/include/asm-m68k/signal.h
+++ b/include/asm-m68k/signal.h
@@ -156,13 +156,13 @@ #define __HAVE_ARCH_SIG_BITOPS
 
 static inline void sigaddset(sigset_t *set, int _sig)
 {
-	__asm__("bfset %0{%1,#1}" : "=m" (*set) : "id" ((_sig - 1) ^ 31)
+	__asm__("bfset %0{%1,#1}" : "=o" (*set) : "id" ((_sig - 1) ^ 31)
 		: "cc");
 }
 
 static inline void sigdelset(sigset_t *set, int _sig)
 {
-	__asm__("bfclr %0{%1,#1}" : "=m"(*set) : "id"((_sig - 1) ^ 31)
+	__asm__("bfclr %0{%1,#1}" : "=o"(*set) : "id"((_sig - 1) ^ 31)
 		: "cc");
 }
 
@@ -176,7 +176,7 @@ static inline int __gen_sigismember(sigs
 {
 	int ret;
 	__asm__("bfextu %1{%2,#1},%0"
-		: "=d"(ret) : "m"(*set), "id"((_sig-1) ^ 31));
+		: "=d"(ret) : "o"(*set), "id"((_sig-1) ^ 31));
 	return ret;
 }
 
-- 
1.3.GIT

Re: [PATCH] m68k: bogus constraints in signal.h

[Roman Zippel]

Hi,

On Thu, 15 Jun 2006, Al Viro wrote:

> bfset and friends need "o", not "m" - they don't work with autodecrement
> memory arguments.  bitops.h had it fixed, signal.h hadn't...

I have a better version for this one pending, which I have queued for 
2.6.18.

bye, Roman

Re: [PATCH] m68k: bogus constraints in signal.h

[Al Viro]

On Thu, Jun 15, 2006 at 01:46:55PM +0200, Roman Zippel wrote:
> Hi,
> 
> On Thu, 15 Jun 2006, Al Viro wrote:
> 
> > bfset and friends need "o", not "m" - they don't work with autodecrement
> > memory arguments.  bitops.h had it fixed, signal.h hadn't...
> 
> I have a better version for this one pending, which I have queued for 
> 2.6.18.

Could you post it?

Re: [PATCH] m68k: bogus constraints in signal.h

[Roman Zippel]

Hi,

On Thu, 15 Jun 2006, Al Viro wrote:

> On Thu, Jun 15, 2006 at 01:46:55PM +0200, Roman Zippel wrote:
> > Hi,
> > 
> > On Thu, 15 Jun 2006, Al Viro wrote:
> > 
> > > bfset and friends need "o", not "m" - they don't work with autodecrement
> > > memory arguments.  bitops.h had it fixed, signal.h hadn't...
> > 
> > I have a better version for this one pending, which I have queued for 
> > 2.6.18.
> 
> Could you post it?

http://marc.theaimsgroup.com/?l=linux-m68k-cvscommit&m=114954838727448&w=2

bye, Roman