From: Adrian Bunk <bunk@stusta.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/mtd/devices/: remove dead _ecc code
Date: Tue, 27 Jun 2006 15:11:16 +0200 [thread overview]
Message-ID: <20060627131116.GL23314@stusta.de> (raw)
In-Reply-To: <1150928664.25491.34.camel@localhost.localdomain>
On Thu, Jun 22, 2006 at 12:24:24AM +0200, Thomas Gleixner wrote:
> On Wed, 2006-06-21 at 23:58 +0200, Adrian Bunk wrote:
> > This patch removes some code that is dead code after the
> > "Remove read/write _ecc variants" patch that went into Linus' tree.
>
> Holy cow, are you even remotly knowing what you are doing ?
>
> Removing the xxx_ecc function pointers from the mtd structs does not
> remove the fundamental requirement of ECC for NAND FLASH.
>
> I'm just waiting for the follow up patches which remove nand_ecc and the
> reed solomon library.
>...
nand_ecc isn't dead code.
But if I do understand correctly, you have pending patches to let the
code your patch made dead code and my patch would have removed be used
again?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/mtd/devices/: remove dead _ecc code
Date: Tue, 27 Jun 2006 15:11:16 +0200 [thread overview]
Message-ID: <20060627131116.GL23314@stusta.de> (raw)
In-Reply-To: <1150928664.25491.34.camel@localhost.localdomain>
On Thu, Jun 22, 2006 at 12:24:24AM +0200, Thomas Gleixner wrote:
> On Wed, 2006-06-21 at 23:58 +0200, Adrian Bunk wrote:
> > This patch removes some code that is dead code after the
> > "Remove read/write _ecc variants" patch that went into Linus' tree.
>
> Holy cow, are you even remotly knowing what you are doing ?
>
> Removing the xxx_ecc function pointers from the mtd structs does not
> remove the fundamental requirement of ECC for NAND FLASH.
>
> I'm just waiting for the follow up patches which remove nand_ecc and the
> reed solomon library.
>...
nand_ecc isn't dead code.
But if I do understand correctly, you have pending patches to let the
code your patch made dead code and my patch would have removed be used
again?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2006-06-27 13:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-21 21:58 [2.6 patch] drivers/mtd/devices/: remove dead _ecc code Adrian Bunk
2006-06-21 22:24 ` Thomas Gleixner
2006-06-21 22:24 ` Thomas Gleixner
2006-06-27 13:11 ` Adrian Bunk [this message]
2006-06-27 13:11 ` Adrian Bunk
2006-06-28 7:16 ` Thomas Gleixner
2006-06-28 7:16 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060627131116.GL23314@stusta.de \
--to=bunk@stusta.de \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.