All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Dave Jones <davej@redhat.com>
Subject: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS
Date: Wed, 28 Jun 2006 18:54:40 +0200	[thread overview]
Message-ID: <20060628165440.GO13915@stusta.de> (raw)

Currently, using an undeclared function gives a compile warning, but it 
can lead to a nasty to debug runtime stack corruptions if the prototype 
of the function is different from what gcc guessed.

With -Werror-implicit-function-declaration we are getting an immediate
compile error instead.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 Makefile                               |    3 ++-
 drivers/input/joystick/iforce/Makefile |    2 --
 2 files changed, 2 insertions(+), 3 deletions(-)

--- linux-2.6.17-mm3-full/Makefile.old	2006-06-27 11:06:51.000000000 +0200
+++ linux-2.6.17-mm3-full/Makefile	2006-06-27 11:07:12.000000000 +0200
@@ -317,7 +317,8 @@
 CPPFLAGS        := -D__KERNEL__ $(LINUXINCLUDE)
 
 CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
-                   -fno-strict-aliasing -fno-common
+                   -fno-strict-aliasing -fno-common \
+		   -Werror-implicit-function-declaration
 AFLAGS          := -D__ASSEMBLY__
 
 # Read KERNELRELEASE from include/config/kernel.release (if it exists)
--- linux-2.6.17-mm3-full/drivers/input/joystick/iforce/Makefile.old	2006-06-27 11:07:20.000000000 +0200
+++ linux-2.6.17-mm3-full/drivers/input/joystick/iforce/Makefile	2006-06-27 11:07:32.000000000 +0200
@@ -16,5 +16,3 @@
 ifeq ($(CONFIG_JOYSTICK_IFORCE_USB),y)
 	iforce-objs += iforce-usb.o
 endif
-
-EXTRA_CFLAGS = -Werror-implicit-function-declaration


             reply	other threads:[~2006-06-28 16:54 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-28 16:54 Adrian Bunk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-07-07 17:10 [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS Luck, Tony
2006-07-07 17:10 ` Luck, Tony
2006-07-06 16:37 Adrian Bunk
2006-07-06 18:05 ` Jesper Juhl
2006-07-06 18:20 ` Dave Jones
2006-07-07  3:36 ` Sam Ravnborg
2006-07-07  5:02   ` Valdis.Kletnieks
2006-07-07  6:42     ` Sam Ravnborg
2006-07-07  7:49       ` Adrian Bunk
2006-07-07  7:53     ` Milton Miller
2006-07-07  7:18   ` Adrian Bunk
2006-07-07  7:49   ` Heiko Carstens
2006-07-07  9:33     ` Sam Ravnborg
2005-11-23 22:34 Adrian Bunk
2005-11-23 23:09 ` Andrew Morton
2005-11-23 23:38   ` Adrian Bunk
2005-11-23 23:50     ` Andrew Morton
2005-11-24  0:13       ` Adrian Bunk
2005-11-07 20:03 Adrian Bunk
2005-11-10 12:28 ` Andrew Morton
2005-11-11  2:12   ` Adrian Bunk
2005-11-11  2:24     ` Andrew Morton
2005-11-11  3:45       ` Randy.Dunlap
2005-11-11 20:18       ` Adrian Bunk
2005-11-11 20:20         ` Adrian Bunk
2005-11-11 20:36           ` Adrian Bunk
2005-11-11 21:24         ` Andrew Morton
2005-11-11 23:34           ` Sam Ravnborg
2005-11-12  0:33         ` Adrian Bunk
2005-08-30 14:54 Adrian Bunk
2005-08-30 16:18 ` Olaf Hering
2005-08-30 16:29   ` Adrian Bunk
2005-08-30 16:38     ` Olaf Hering
2005-08-30 16:48       ` Adrian Bunk
2005-07-30 16:52 Adrian Bunk
2005-07-30 18:08 ` Andrew Morton
2005-07-30 19:44   ` Adrian Bunk
2005-07-30 18:52 ` Sam Ravnborg
2005-07-30 18:59   ` Christoph Hellwig
2005-07-30 19:40     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060628165440.GO13915@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.