Re: [PATCH] bcm43xx-softmac: Init, shutdown and restart fixes

[Michael Buesch <mb@bu3sch.de>]

On Monday 21 August 2006 16:43, Larry Finger wrote:
> Hi John,
> 
> Please apply this to wireless-2.6.
> 
> Larry
> 
> --
> 
> This fixes various bugs in the init and shutdown code
> that would lead to lockups and crashes, and is the softmac
> equivalent of the patches submitted by Michael Buesch for
> bcm43xx-d80211.
> These changes may fix some of the NETDEV WATCHDOG transmit
> timeouts, but they do not fix all of them, at least not in softmac.
> 
> Signed-Off-By: Larry Finger <Larry.Finger@lwfinger.net>
> 
> ===============================

Next time please inline the patch.

> @@ -3537,11 +3536,10 @@ static int bcm43xx_init_board(struct bcm
>         err = bcm43xx_select_wireless_core(bcm, -1);
>         if (err)
>                 goto err_crystal_off;
> -
> -       bcm43xx_periodic_tasks_setup(bcm);
>         err = bcm43xx_sysfs_register(bcm);
>         if (err)
>                 goto err_wlshutdown;
> +       bcm43xx_periodic_tasks_setup(bcm);
>         err = bcm43xx_rng_init(bcm);
>         if (err)
>                 goto err_sysfs_unreg;

Either move bcm43xx_periodic_tasks_setup after rng_init, or
delete the periodic work again, if rng_init fails.


-- 
Greetings Michael.