From: "John W. Linville" <linville@tuxdriver.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: Larry Finger <Larry.Finger@lwfinger.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] bcm43xx-softmac: Init, shutdown and restart fixes
Date: Mon, 11 Sep 2006 14:29:02 -0400 [thread overview]
Message-ID: <20060911182857.GA19326@tuxdriver.com> (raw)
In-Reply-To: <200608211653.01997.mb@bu3sch.de>
On Mon, Aug 21, 2006 at 04:52:58PM +0200, Michael Buesch wrote:
> On Monday 21 August 2006 16:43, Larry Finger wrote:
> > @@ -3537,11 +3536,10 @@ static int bcm43xx_init_board(struct bcm
> > err = bcm43xx_select_wireless_core(bcm, -1);
> > if (err)
> > goto err_crystal_off;
> > -
> > - bcm43xx_periodic_tasks_setup(bcm);
> > err = bcm43xx_sysfs_register(bcm);
> > if (err)
> > goto err_wlshutdown;
> > + bcm43xx_periodic_tasks_setup(bcm);
> > err = bcm43xx_rng_init(bcm);
> > if (err)
> > goto err_sysfs_unreg;
>
> Either move bcm43xx_periodic_tasks_setup after rng_init, or
> delete the periodic work again, if rng_init fails.
Larry, will you be posting another patch to account for these comments?
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2006-09-11 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-21 14:43 [PATCH] bcm43xx-softmac: Init, shutdown and restart fixes Larry Finger
2006-08-21 14:52 ` Michael Buesch
2006-09-11 18:29 ` John W. Linville [this message]
2006-09-11 19:35 ` Larry Finger
2006-09-11 19:36 ` [PATCH] Correct out of sequence initialization step for bcm43xx-softmac Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060911182857.GA19326@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.