All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Michael Buesch <mb@bu3sch.de>, netdev@vger.kernel.org
Subject: [PATCH] Correct out of sequence initialization step for bcm43xx-softmac
Date: Mon, 11 Sep 2006 14:36:35 -0500	[thread overview]
Message-ID: <4505BAC3.2020406@lwfinger.net> (raw)
In-Reply-To: <20060911182857.GA19326@tuxdriver.com>

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

John,

Please apply the following patch to wireless-2.6. It addresses Michael 
Buesch's comments, which I seem to have missed, regarding the previous 
patch entitled "bcm43xx-softmac: Init, shutdown and restart fixes".

My copy of the wireless-2.6 indicates that the original patch has 
already been applied, thus this one only moves the call to 
bcm43xx_periodic_tasks_setup.

Larry

===============================

This patch fixes an out of sequence step in the bcm43xx_init_board 
routine for bcm43xx-softmac.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -3540,13 +3540,13 @@ static int bcm43xx_init_board(struct bcm
  	if (err)
  		goto err_crystal_off;

-	bcm43xx_periodic_tasks_setup(bcm);
  	err = bcm43xx_sysfs_register(bcm);
  	if (err)
  		goto err_wlshutdown;
  	err = bcm43xx_rng_init(bcm);
  	if (err)
  		goto err_sysfs_unreg;
+	bcm43xx_periodic_tasks_setup(bcm);

  	/*FIXME: This should be handled by softmac instead. */
  	schedule_work(&bcm->softmac->associnfo.work);


[-- Attachment #2: patch_rng_init --]
[-- Type: text/plain, Size: 683 bytes --]

Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -3540,13 +3540,13 @@ static int bcm43xx_init_board(struct bcm
 	if (err)
 		goto err_crystal_off;
 
-	bcm43xx_periodic_tasks_setup(bcm);
 	err = bcm43xx_sysfs_register(bcm);
 	if (err)
 		goto err_wlshutdown;
 	err = bcm43xx_rng_init(bcm);
 	if (err)
 		goto err_sysfs_unreg;
+	bcm43xx_periodic_tasks_setup(bcm);
 
 	/*FIXME: This should be handled by softmac instead. */
 	schedule_work(&bcm->softmac->associnfo.work);


      parent reply	other threads:[~2006-09-11 19:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-21 14:43 [PATCH] bcm43xx-softmac: Init, shutdown and restart fixes Larry Finger
2006-08-21 14:52 ` Michael Buesch
2006-09-11 18:29   ` John W. Linville
2006-09-11 19:35     ` Larry Finger
2006-09-11 19:36     ` Larry Finger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4505BAC3.2020406@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.