* Incorrect alignment assumptions in x86_64 stacktrace
@ 2006-08-25 6:59 Keith Owens
2006-08-25 7:33 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: Keith Owens @ 2006-08-25 6:59 UTC (permalink / raw)
To: linux-kernel; +Cc: ak
2.6.18-rc4 arch/x86_64/kernel/stacktrace.c::get_stack_end() incorrectly
assumes that the irqstackptr is IRQSTACKSIZE aligned.
stack_end = (unsigned long)cpu_pda(cpu)->irqstackptr;
if (stack_end) {
stack_start = stack_end & ~(IRQSTACKSIZE-1);
irqstackptr is only guaranteed to be page aligned, not IRQSTACKSIZE
(4*PAGE_SIZE) aligned.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Incorrect alignment assumptions in x86_64 stacktrace
2006-08-25 6:59 Incorrect alignment assumptions in x86_64 stacktrace Keith Owens
@ 2006-08-25 7:33 ` Andi Kleen
2006-08-25 7:43 ` Keith Owens
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2006-08-25 7:33 UTC (permalink / raw)
To: Keith Owens; +Cc: linux-kernel, mingo
On Friday 25 August 2006 08:59, Keith Owens wrote:
> 2.6.18-rc4 arch/x86_64/kernel/stacktrace.c::get_stack_end() incorrectly
> assumes that the irqstackptr is IRQSTACKSIZE aligned.
>
> stack_end = (unsigned long)cpu_pda(cpu)->irqstackptr;
> if (stack_end) {
> stack_start = stack_end & ~(IRQSTACKSIZE-1);
>
> irqstackptr is only guaranteed to be page aligned, not IRQSTACKSIZE
> (4*PAGE_SIZE) aligned.
Thanks. I have already removed that code post 2.6.18 (the standard backtracer
now does both stacktrace and show_trace)
You think it is important enough for 2.6.18?
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Incorrect alignment assumptions in x86_64 stacktrace
2006-08-25 7:33 ` Andi Kleen
@ 2006-08-25 7:43 ` Keith Owens
0 siblings, 0 replies; 3+ messages in thread
From: Keith Owens @ 2006-08-25 7:43 UTC (permalink / raw)
To: Andi Kleen; +Cc: linux-kernel, mingo
Andi Kleen (on Fri, 25 Aug 2006 09:33:53 +0200) wrote:
>On Friday 25 August 2006 08:59, Keith Owens wrote:
>> 2.6.18-rc4 arch/x86_64/kernel/stacktrace.c::get_stack_end() incorrectly
>> assumes that the irqstackptr is IRQSTACKSIZE aligned.
>>
>> stack_end = (unsigned long)cpu_pda(cpu)->irqstackptr;
>> if (stack_end) {
>> stack_start = stack_end & ~(IRQSTACKSIZE-1);
>>
>> irqstackptr is only guaranteed to be page aligned, not IRQSTACKSIZE
>> (4*PAGE_SIZE) aligned.
>
>Thanks. I have already removed that code post 2.6.18 (the standard backtracer
>now does both stacktrace and show_trace)
>
>You think it is important enough for 2.6.18?
Depends if any x86_64 distributions are going to be based on 2.6.18. I
hear rumours, but no facts.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-08-25 7:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-25 6:59 Incorrect alignment assumptions in x86_64 stacktrace Keith Owens
2006-08-25 7:33 ` Andi Kleen
2006-08-25 7:43 ` Keith Owens
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.