From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Pointed by kj-devel.pl over drivers/ide/ide.c
Date: Mon, 04 Sep 2006 22:13:55 +0000 [thread overview]
Message-ID: <20060904221355.GE26935@nd47.coderock.org> (raw)
In-Reply-To: <20060902233239.4A23C49B6BE@ws1-3a.us4.outblaze.com>
On 02/09/06 18:32 -0500, Mauricio Mauad wrote:
> Hi,
>
> I'm just sending you a very simple patch just to follow the guidelines
> pointed on the TODO list. That's the way? If yes, I will send you some more.
Missing description, "Signed-off-by:".
>
> diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
> index 3fdab56..3276391 100644
> --- a/drivers/ide/ide.c
> +++ b/drivers/ide/ide.c
> @@ -1427,8 +1427,8 @@ static int __init stridx (const char *s,
> */
> static int __init match_parm (char *s, const char *keywords[], int vals[], int max_vals)
> {
> - static const char *decimal = "0123456789";
> - static const char *hex = "0123456789abcdef";
> + static const char decimal[] = "0123456789";
> + static const char hex[] = "0123456789abcdef";
size(1) output would be nice for these.
And in this case using a common global variable would be better.
It should save more space.
Domen
> int i, n;
>
> if (*s++ = '=') {
>
>
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/kernel-janitors
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2006-09-04 22:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-02 23:32 [KJ] [PATCH] Pointed by kj-devel.pl over drivers/ide/ide.c Mauricio Mauad
2006-09-04 22:13 ` Domen Puncer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060904221355.GE26935@nd47.coderock.org \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.