* [KJ] [PATCH] Pointed by kj-devel.pl over drivers/ide/ide.c
@ 2006-09-02 23:32 Mauricio Mauad
2006-09-04 22:13 ` Domen Puncer
0 siblings, 1 reply; 2+ messages in thread
From: Mauricio Mauad @ 2006-09-02 23:32 UTC (permalink / raw)
To: kernel-janitors
Hi,
I'm just sending you a very simple patch just to follow the guidelines
pointed on the TODO list. That's the way? If yes, I will send you some more.
diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
index 3fdab56..3276391 100644
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -1427,8 +1427,8 @@ static int __init stridx (const char *s,
*/
static int __init match_parm (char *s, const char *keywords[], int vals[], int max_vals)
{
- static const char *decimal = "0123456789";
- static const char *hex = "0123456789abcdef";
+ static const char decimal[] = "0123456789";
+ static const char hex[] = "0123456789abcdef";
int i, n;
if (*s++ = '=') {
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [KJ] [PATCH] Pointed by kj-devel.pl over drivers/ide/ide.c
2006-09-02 23:32 [KJ] [PATCH] Pointed by kj-devel.pl over drivers/ide/ide.c Mauricio Mauad
@ 2006-09-04 22:13 ` Domen Puncer
0 siblings, 0 replies; 2+ messages in thread
From: Domen Puncer @ 2006-09-04 22:13 UTC (permalink / raw)
To: kernel-janitors
On 02/09/06 18:32 -0500, Mauricio Mauad wrote:
> Hi,
>
> I'm just sending you a very simple patch just to follow the guidelines
> pointed on the TODO list. That's the way? If yes, I will send you some more.
Missing description, "Signed-off-by:".
>
> diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
> index 3fdab56..3276391 100644
> --- a/drivers/ide/ide.c
> +++ b/drivers/ide/ide.c
> @@ -1427,8 +1427,8 @@ static int __init stridx (const char *s,
> */
> static int __init match_parm (char *s, const char *keywords[], int vals[], int max_vals)
> {
> - static const char *decimal = "0123456789";
> - static const char *hex = "0123456789abcdef";
> + static const char decimal[] = "0123456789";
> + static const char hex[] = "0123456789abcdef";
size(1) output would be nice for these.
And in this case using a common global variable would be better.
It should save more space.
Domen
> int i, n;
>
> if (*s++ = '=') {
>
>
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/kernel-janitors
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-09-04 22:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-02 23:32 [KJ] [PATCH] Pointed by kj-devel.pl over drivers/ide/ide.c Mauricio Mauad
2006-09-04 22:13 ` Domen Puncer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.