[KJ] [PATCH] Pointed by kj-devel.pl over drivers/ide/ide.c

[KJ] [PATCH] Pointed by kj-devel.pl over drivers/ide/ide.c

[Mauricio Mauad]

Hi,

    I'm just sending you a very simple patch just to follow the guidelines
pointed on the TODO list. That's the way? If yes, I will send you some more.

diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
index 3fdab56..3276391 100644
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -1427,8 +1427,8 @@ static int __init stridx (const char *s,
  */
 static int __init match_parm (char *s, const char *keywords[], int vals[], int max_vals)
 {
-       static const char *decimal = "0123456789";
-       static const char *hex = "0123456789abcdef";
+       static const char decimal[] = "0123456789";
+       static const char hex[] = "0123456789abcdef";
        int i, n;

        if (*s++ = '=') {


_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] Pointed by kj-devel.pl over drivers/ide/ide.c

[Domen Puncer]

On 02/09/06 18:32 -0500, Mauricio Mauad wrote:
> Hi,
> 
>     I'm just sending you a very simple patch just to follow the guidelines
> pointed on the TODO list. That's the way? If yes, I will send you some more.

Missing description, "Signed-off-by:".
> 
> diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
> index 3fdab56..3276391 100644
> --- a/drivers/ide/ide.c
> +++ b/drivers/ide/ide.c
> @@ -1427,8 +1427,8 @@ static int __init stridx (const char *s,
>   */
>  static int __init match_parm (char *s, const char *keywords[], int vals[], int max_vals)
>  {
> -       static const char *decimal = "0123456789";
> -       static const char *hex = "0123456789abcdef";
> +       static const char decimal[] = "0123456789";
> +       static const char hex[] = "0123456789abcdef";

size(1) output would be nice for these.

And in this case using a common global variable would be better.
It should save more space.


	Domen

>         int i, n;
> 
>         if (*s++ = '=') {
> 
> 
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/kernel-janitors
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors