From: Stephen Hemminger <shemminger@osdl.org>
To: David Miller <davem@davemloft.net>
Cc: bert.hubert@netherlabs.nl, netdev@vger.kernel.org
Subject: Re: [PATCH] tcp: simpler bic default
Date: Tue, 19 Sep 2006 16:02:02 -0700 [thread overview]
Message-ID: <20060919160202.23390471@localhost.localdomain> (raw)
In-Reply-To: <20060919.154435.102044066.davem@davemloft.net>
> When TCP_CONG_ADVANCED is disabled, TCP_CONG_BIC should always be set
> and be the default, but that's not what the new code is doing.
>
> I'm reverting Stephen's patch (again) until this is all sorted
> out as things are still broken in various ways even with the
> followon patch.
I don't see what's wrong, this is on a kernel with the two patches:
After "make defconfig"
# CONFIG_TCP_CONG_ADVANCED is not set
CONFIG_DEFAULT_TCP_CONG="bic"
# CONFIG_NETFILTER_XT_MATCH_TCPMSS is not set
# CONFIG_IP_NF_TARGET_TCPMSS is not set
# CONFIG_ISCSI_TCP is not set
Enable TCP_ADVANCED_CONG with make menuconfig
CONFIG_TCP_CONG_ADVANCED=y
# TCP congestion control
CONFIG_TCP_CONG_BIC=y
CONFIG_TCP_CONG_CUBIC=m
CONFIG_TCP_CONG_WESTWOOD=m
CONFIG_TCP_CONG_HTCP=m
# CONFIG_TCP_CONG_HSTCP is not set
# CONFIG_TCP_CONG_HYBLA is not set
# CONFIG_TCP_CONG_VEGAS is not set
# CONFIG_TCP_CONG_SCALABLE is not set
# CONFIG_TCP_CONG_LP is not set
# CONFIG_TCP_CONG_VENO is not set
# CONFIG_DEFAULT_HTCP is not set
CONFIG_DEFAULT_TCP_CONG="bic"
After "make allmodconfig"
CONFIG_INET_TCP_DIAG=m
CONFIG_TCP_CONG_ADVANCED=y
# TCP congestion control
CONFIG_TCP_CONG_BIC=m
CONFIG_TCP_CONG_CUBIC=m
CONFIG_TCP_CONG_WESTWOOD=m
CONFIG_TCP_CONG_HTCP=m
CONFIG_TCP_CONG_HSTCP=m
CONFIG_TCP_CONG_HYBLA=m
CONFIG_TCP_CONG_VEGAS=m
CONFIG_TCP_CONG_SCALABLE=m
CONFIG_TCP_CONG_LP=m
CONFIG_TCP_CONG_VENO=m
# CONFIG_DEFAULT_HTCP is not set
CONFIG_DEFAULT_TCP_CONG="reno"
After "make allyesconfig"
CONFIG_INET_TCP_DIAG=y
CONFIG_TCP_CONG_ADVANCED=y
# TCP congestion control
CONFIG_TCP_CONG_BIC=y
CONFIG_TCP_CONG_CUBIC=y
CONFIG_TCP_CONG_WESTWOOD=y
CONFIG_TCP_CONG_HTCP=y
CONFIG_TCP_CONG_HSTCP=y
CONFIG_TCP_CONG_HYBLA=y
CONFIG_TCP_CONG_VEGAS=y
CONFIG_TCP_CONG_SCALABLE=y
CONFIG_TCP_CONG_LP=y
CONFIG_TCP_CONG_VENO=y
# CONFIG_DEFAULT_HTCP is not set
CONFIG_DEFAULT_TCP_CONG="bic"
next prev parent reply other threads:[~2006-09-19 23:02 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-16 22:19 2.6.18-rc[67] crashes in TCP ack handling bert hubert
2006-09-16 23:32 ` Stephen Hemminger
2006-09-17 10:11 ` bert hubert
2006-09-17 11:53 ` Stephen Hemminger
[not found] ` <20060917122153.GA2932@outpost.ds9a.nl>
2006-09-17 13:11 ` tcp congestion policy selection link order fragile Stephen Hemminger
2006-09-17 14:51 ` bert hubert
2006-09-18 23:41 ` Stephen Hemminger
2006-09-18 8:51 ` David Miller
2006-09-18 9:59 ` bert hubert
2006-09-18 14:06 ` David Miller
2006-09-18 15:40 ` bert hubert
2006-09-18 18:53 ` David Miller
2006-09-18 19:52 ` bert hubert
2006-09-19 4:41 ` [PATCH] tcp: set congestion default through Kconfig Stephen Hemminger
2006-09-19 5:08 ` Ian McDonald
2006-09-19 10:03 ` Andi Kleen
2006-09-19 12:35 ` Hagen Paul Pfeifer
2006-09-19 16:10 ` David Miller
2006-09-19 17:28 ` Stephen Hemminger
2006-09-19 15:29 ` Stephen Hemminger
2006-09-19 19:29 ` David Miller
2006-09-19 19:30 ` David Miller
2006-09-19 19:33 ` David Miller
2006-09-19 19:39 ` Stephen Hemminger
2006-09-19 20:41 ` [PATCH] tcp: set congestion default through Kconfig (v2) Stephen Hemminger
2006-09-19 21:20 ` David Miller
2006-09-19 21:32 ` [PATCH] tcp: simpler bic default Stephen Hemminger
2006-09-19 21:43 ` bert hubert
2006-09-19 22:44 ` David Miller
2006-09-19 23:02 ` Stephen Hemminger [this message]
2006-09-19 23:04 ` David Miller
2006-09-19 23:23 ` Stephen Hemminger
2006-09-20 8:17 ` bert hubert
2006-09-20 20:28 ` [PATCH] tcp: default congestion control menu Stephen Hemminger
2006-09-25 3:12 ` David Miller
2006-09-20 20:32 ` [PATCH] tcp: make cubic the default Stephen Hemminger
2006-09-23 11:14 ` tested: " bert hubert
2006-09-23 20:00 ` David Miller
2006-09-25 3:13 ` David Miller
2006-09-19 21:38 ` [PATCH] tcp: set congestion default through Kconfig (v2) bert hubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060919160202.23390471@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=bert.hubert@netherlabs.nl \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.