From: Stephen Hemminger <shemminger@osdl.org>
To: David Miller <davem@davemloft.net>
Cc: bert.hubert@netherlabs.nl, netdev@vger.kernel.org
Subject: Re: [PATCH] tcp: simpler bic default
Date: Tue, 19 Sep 2006 16:23:55 -0700 [thread overview]
Message-ID: <20060919162355.3a22fec1@localhost.localdomain> (raw)
In-Reply-To: <20060919.160441.66322371.davem@davemloft.net>
On Tue, 19 Sep 2006 16:04:41 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@osdl.org>
> Date: Tue, 19 Sep 2006 16:02:02 -0700
>
> >
> > > When TCP_CONG_ADVANCED is disabled, TCP_CONG_BIC should always be set
> > > and be the default, but that's not what the new code is doing.
> > >
> > > I'm reverting Stephen's patch (again) until this is all sorted
> > > out as things are still broken in various ways even with the
> > > followon patch.
> >
> > I don't see what's wrong, this is on a kernel with the two patches:
>
> Look more closely:
>
> > After "make defconfig"
> > # CONFIG_TCP_CONG_ADVANCED is not set
> > CONFIG_DEFAULT_TCP_CONG="bic"
> > # CONFIG_NETFILTER_XT_MATCH_TCPMSS is not set
> > # CONFIG_IP_NF_TARGET_TCPMSS is not set
> > # CONFIG_ISCSI_TCP is not set
>
> But TCP_CONG_BIC isn't enabled so it won't get built nor be
> the default algorithm. When CONG_ADVANCED is off, as it is here,
> TCP_CONG_BIC should be "y". That's what happens before your
> changes.
Okay, build testing all the possibilities now, answer by morning..
--
Stephen Hemminger <shemminger@osdl.org>
next prev parent reply other threads:[~2006-09-19 23:24 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-16 22:19 2.6.18-rc[67] crashes in TCP ack handling bert hubert
2006-09-16 23:32 ` Stephen Hemminger
2006-09-17 10:11 ` bert hubert
2006-09-17 11:53 ` Stephen Hemminger
[not found] ` <20060917122153.GA2932@outpost.ds9a.nl>
2006-09-17 13:11 ` tcp congestion policy selection link order fragile Stephen Hemminger
2006-09-17 14:51 ` bert hubert
2006-09-18 23:41 ` Stephen Hemminger
2006-09-18 8:51 ` David Miller
2006-09-18 9:59 ` bert hubert
2006-09-18 14:06 ` David Miller
2006-09-18 15:40 ` bert hubert
2006-09-18 18:53 ` David Miller
2006-09-18 19:52 ` bert hubert
2006-09-19 4:41 ` [PATCH] tcp: set congestion default through Kconfig Stephen Hemminger
2006-09-19 5:08 ` Ian McDonald
2006-09-19 10:03 ` Andi Kleen
2006-09-19 12:35 ` Hagen Paul Pfeifer
2006-09-19 16:10 ` David Miller
2006-09-19 17:28 ` Stephen Hemminger
2006-09-19 15:29 ` Stephen Hemminger
2006-09-19 19:29 ` David Miller
2006-09-19 19:30 ` David Miller
2006-09-19 19:33 ` David Miller
2006-09-19 19:39 ` Stephen Hemminger
2006-09-19 20:41 ` [PATCH] tcp: set congestion default through Kconfig (v2) Stephen Hemminger
2006-09-19 21:20 ` David Miller
2006-09-19 21:32 ` [PATCH] tcp: simpler bic default Stephen Hemminger
2006-09-19 21:43 ` bert hubert
2006-09-19 22:44 ` David Miller
2006-09-19 23:02 ` Stephen Hemminger
2006-09-19 23:04 ` David Miller
2006-09-19 23:23 ` Stephen Hemminger [this message]
2006-09-20 8:17 ` bert hubert
2006-09-20 20:28 ` [PATCH] tcp: default congestion control menu Stephen Hemminger
2006-09-25 3:12 ` David Miller
2006-09-20 20:32 ` [PATCH] tcp: make cubic the default Stephen Hemminger
2006-09-23 11:14 ` tested: " bert hubert
2006-09-23 20:00 ` David Miller
2006-09-25 3:13 ` David Miller
2006-09-19 21:38 ` [PATCH] tcp: set congestion default through Kconfig (v2) bert hubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060919162355.3a22fec1@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=bert.hubert@netherlabs.nl \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.