From: Andi Kleen <ak@muc.de>
To: Hugh Dickins <hugh@veritas.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Put the BUG __FILE__ and __LINE__ info out of line
Date: 28 Sep 2006 21:44:18 +0200
Date: Thu, 28 Sep 2006 21:44:18 +0200 [thread overview]
Message-ID: <20060928194418.GA51533@muc.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0609281626001.25939@blonde.wat.veritas.com>
On Thu, Sep 28, 2006 at 04:30:19PM +0100, Hugh Dickins wrote:
> On Thu, 28 Sep 2006, Andi Kleen wrote:
> > On Thu, Sep 28, 2006 at 03:30:12AM -0700, Jeremy Fitzhardinge wrote:
> > > Andi Kleen wrote:
> > > >But no out of line section. So overall it's smaller, although the cache
> > > >footprint
> > > >is 2 bytes larger. But then is 2 bytes larger really an issue? We don't
> > > >have
> > > >_that_ many BUGs anyways.
> > > >
> > >
> > > I think the out of line section is a feature; no point in crufting up
> > > the icache with BUG gunk, especially since a number of them are on
> > > fairly hot paths.
> >
> > It's 10 bytes per BUG.
>
> Or 9 bytes per BUG: I protested about the disassembly problem back
> when the minimized BUG() first went in, and have been using "ljmp"
> in my i386 builds ever since:
Good point.
Need to check if that works on x86-64 too.
-Andi
next prev parent reply other threads:[~2006-09-28 19:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 6:00 [PATCH] Put the BUG __FILE__ and __LINE__ info out of line Jeremy Fitzhardinge
2006-09-28 6:35 ` Andrew Morton
2006-09-28 6:49 ` Jeremy Fitzhardinge
2006-09-28 7:00 ` Andrew Morton
2006-09-28 7:17 ` Andi Kleen
2006-09-28 7:26 ` Andrew Morton
2006-09-28 10:15 ` Andi Kleen
2006-09-28 10:30 ` Jeremy Fitzhardinge
2006-09-28 10:38 ` Andi Kleen
2006-09-28 15:30 ` Hugh Dickins
2006-09-28 19:44 ` Andi Kleen [this message]
2006-09-28 10:27 ` Jeremy Fitzhardinge
2006-09-28 16:18 ` Andrew Morton
2006-09-28 16:32 ` Jeremy Fitzhardinge
2006-09-28 7:16 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060928194418.GA51533@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.