From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Andi Kleen <ak@muc.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Put the BUG __FILE__ and __LINE__ info out of line
Date: Wed, 27 Sep 2006 23:49:49 -0700 [thread overview]
Message-ID: <451B708D.20505@goop.org> (raw)
In-Reply-To: <20060927233509.f675c02d.akpm@osdl.org>
Andrew Morton wrote:
> hm. Bigger vmlinux, smaller .text.
>
Yep.
> It means that we'll hit handle_BUG with that extra EIP pushed on the stack.
> What does that do to the stack trace, and to the unwinder?
>
Dunno. I was hoping Andi would pop up with the appropriate CFI gunk, if
necessary. But the reason for making it a call was to make it as
unwindable as possible.
> It'll also muck up the displayed EIP, not that that matters a lot (well, it
> might matter a bit if the BUG is in an inlined function).
>
> We could get the correct EIP by fishing it off the stack (and subtracting
> five from it?)
>
Yes, that's possible.
> Or we could assume that BUG doesn't return (it doesn't) and make that call
> a jmp. But then we'd really lose the EIP.
Right. Or it could save the EIP along with the line and filename.
J
next prev parent reply other threads:[~2006-09-28 6:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 6:00 [PATCH] Put the BUG __FILE__ and __LINE__ info out of line Jeremy Fitzhardinge
2006-09-28 6:35 ` Andrew Morton
2006-09-28 6:49 ` Jeremy Fitzhardinge [this message]
2006-09-28 7:00 ` Andrew Morton
2006-09-28 7:17 ` Andi Kleen
2006-09-28 7:26 ` Andrew Morton
2006-09-28 10:15 ` Andi Kleen
2006-09-28 10:30 ` Jeremy Fitzhardinge
2006-09-28 10:38 ` Andi Kleen
2006-09-28 15:30 ` Hugh Dickins
2006-09-28 19:44 ` Andi Kleen
2006-09-28 10:27 ` Jeremy Fitzhardinge
2006-09-28 16:18 ` Andrew Morton
2006-09-28 16:32 ` Jeremy Fitzhardinge
2006-09-28 7:16 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451B708D.20505@goop.org \
--to=jeremy@goop.org \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.