[PATCH] off-by-one in kernel command line option parsing

[PATCH] off-by-one in kernel command line option parsing

[Vincent Legoll]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

Here is a patch for what I think is a bug in the kernel,
please comment / apply as appropriate.

Generated by cg-mkpatch from a fairly recent git tree.
Cross-compile tested.

-- 
Vincent Legoll


[-- Attachment #2: opt-parse.patch --]
[-- Type: text/plain, Size: 845 bytes --]

fix memcmp() off-by-one
nolapic is 7 chars long

---
commit aa2cb4b05c437005ccff44084678948c99aa62b3
tree 54ddca6ab0ef9a29bb1ff0f452b1eaccce7b33a1
parent 4ed4b5475211fab6a0ad00eed2f9297395e7598e
author Vincent Legoll <vincent.legoll@gmail.com> Sat, 30 Sep 2006 18:52:53 +0200
committer Vincent Legoll <vincent.legoll@gmail.com> Sat, 30 Sep 2006 18:52:53 +0200

 arch/i386/kernel/setup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
index f168220..72bbf22 100644
--- a/arch/i386/kernel/setup.c
+++ b/arch/i386/kernel/setup.c
@@ -869,7 +869,7 @@ #ifdef CONFIG_X86_LOCAL_APIC
 			lapic_enable();
 
 		/* disable local APIC */
-		else if (!memcmp(from, "nolapic", 6))
+		else if (!memcmp(from, "nolapic", 7))
 			lapic_disable();
 #endif /* CONFIG_X86_LOCAL_APIC */
 

Re: [PATCH] off-by-one in kernel command line option parsing

[Andi Kleen]

On Saturday 30 September 2006 20:20, Vincent Legoll wrote:
> Here is a patch for what I think is a bug in the kernel,
> please comment / apply as appropriate.


That code is already gone in the latest tree.

-Andi

Re: [PATCH] off-by-one in kernel command line option parsing

[Vincent Legoll]

On 9/30/06, Andi Kleen <ak@suse.de> wrote:
> That code is already gone in the latest tree.

OK, I fumbled with git and checked a not-so-recent
snapshot. Sorry for the noise.

-- 
Vincent Legoll