* [PATCH] off-by-one in kernel command line option parsing
@ 2006-09-30 18:20 Vincent Legoll
2006-09-30 18:25 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: Vincent Legoll @ 2006-09-30 18:20 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds, ak, Vincent Legoll
[-- Attachment #1: Type: text/plain, Size: 195 bytes --]
Here is a patch for what I think is a bug in the kernel,
please comment / apply as appropriate.
Generated by cg-mkpatch from a fairly recent git tree.
Cross-compile tested.
--
Vincent Legoll
[-- Attachment #2: opt-parse.patch --]
[-- Type: text/plain, Size: 845 bytes --]
fix memcmp() off-by-one
nolapic is 7 chars long
---
commit aa2cb4b05c437005ccff44084678948c99aa62b3
tree 54ddca6ab0ef9a29bb1ff0f452b1eaccce7b33a1
parent 4ed4b5475211fab6a0ad00eed2f9297395e7598e
author Vincent Legoll <vincent.legoll@gmail.com> Sat, 30 Sep 2006 18:52:53 +0200
committer Vincent Legoll <vincent.legoll@gmail.com> Sat, 30 Sep 2006 18:52:53 +0200
arch/i386/kernel/setup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
index f168220..72bbf22 100644
--- a/arch/i386/kernel/setup.c
+++ b/arch/i386/kernel/setup.c
@@ -869,7 +869,7 @@ #ifdef CONFIG_X86_LOCAL_APIC
lapic_enable();
/* disable local APIC */
- else if (!memcmp(from, "nolapic", 6))
+ else if (!memcmp(from, "nolapic", 7))
lapic_disable();
#endif /* CONFIG_X86_LOCAL_APIC */
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] off-by-one in kernel command line option parsing
2006-09-30 18:20 [PATCH] off-by-one in kernel command line option parsing Vincent Legoll
@ 2006-09-30 18:25 ` Andi Kleen
2006-09-30 18:32 ` Vincent Legoll
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2006-09-30 18:25 UTC (permalink / raw)
To: Vincent Legoll; +Cc: linux-kernel, torvalds, Vincent Legoll
On Saturday 30 September 2006 20:20, Vincent Legoll wrote:
> Here is a patch for what I think is a bug in the kernel,
> please comment / apply as appropriate.
That code is already gone in the latest tree.
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] off-by-one in kernel command line option parsing
2006-09-30 18:25 ` Andi Kleen
@ 2006-09-30 18:32 ` Vincent Legoll
0 siblings, 0 replies; 3+ messages in thread
From: Vincent Legoll @ 2006-09-30 18:32 UTC (permalink / raw)
To: Andi Kleen; +Cc: Vincent Legoll, linux-kernel, torvalds
On 9/30/06, Andi Kleen <ak@suse.de> wrote:
> That code is already gone in the latest tree.
OK, I fumbled with git and checked a not-so-recent
snapshot. Sorry for the noise.
--
Vincent Legoll
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-09-30 18:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-30 18:20 [PATCH] off-by-one in kernel command line option parsing Vincent Legoll
2006-09-30 18:25 ` Andi Kleen
2006-09-30 18:32 ` Vincent Legoll
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.