From: Jeff Dike <jdike@addtoit.com>
To: Blaisorblade <blaisorblade@yahoo.it>
Cc: linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH 3/8] UML - Fix missing x86_64 register definitions
Date: Sun, 1 Oct 2006 11:11:11 -0400 [thread overview]
Message-ID: <20061001151111.GA3552@ccure.user-mode-linux.org> (raw)
In-Reply-To: <200610011649.08382.blaisorblade@yahoo.it>
On Sun, Oct 01, 2006 at 04:49:07PM +0200, Blaisorblade wrote:
> The patch is ok for me, but frankly, this hunk could be further cleaned up -
> there is an awful hardcoded duplication of code which could be removed (the
> definition could be split away from <sysdep/ptrace.h> if inclusion order hell
> starts).
Yeah, these headers needs some serious cleanup.
Jeff
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Dike <jdike@addtoit.com>
To: Blaisorblade <blaisorblade@yahoo.it>
Cc: user-mode-linux-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [uml-devel] [PATCH 3/8] UML - Fix missing x86_64 register definitions
Date: Sun, 1 Oct 2006 11:11:11 -0400 [thread overview]
Message-ID: <20061001151111.GA3552@ccure.user-mode-linux.org> (raw)
In-Reply-To: <200610011649.08382.blaisorblade@yahoo.it>
On Sun, Oct 01, 2006 at 04:49:07PM +0200, Blaisorblade wrote:
> The patch is ok for me, but frankly, this hunk could be further cleaned up -
> there is an awful hardcoded duplication of code which could be removed (the
> definition could be split away from <sysdep/ptrace.h> if inclusion order hell
> starts).
Yeah, these headers needs some serious cleanup.
Jeff
next prev parent reply other threads:[~2006-10-01 15:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-25 18:34 [uml-devel] [PATCH 3/8] UML - Fix missing x86_64 register definitions Jeff Dike
2006-09-25 18:34 ` Jeff Dike
2006-10-01 14:49 ` [uml-devel] " Blaisorblade
2006-10-01 14:49 ` Blaisorblade
2006-10-01 15:11 ` Jeff Dike [this message]
2006-10-01 15:11 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061001151111.GA3552@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=blaisorblade@yahoo.it \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.