From: "J. Bruce Fields" <bfields@fieldses.org>
To: Andrew Morton <akpm@osdl.org>
Cc: NeilBrown <neilb@suse.de>,
nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH 3 of 3] nfsd4: fslocs: remove spurious NULL check
Date: Mon, 2 Oct 2006 14:26:41 -0400 [thread overview]
Message-ID: <20061002182641.GE8084@fieldses.org> (raw)
In-Reply-To: <20061002182327.GB8084@fieldses.org>
It's obvious that the two callers of this function never call it with NULL.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
---
fs/nfsd/export.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
index ee7b03a..4a11092 100644
--- a/fs/nfsd/export.c
+++ b/fs/nfsd/export.c
@@ -323,9 +323,6 @@ static void nfsd4_fslocs_free(struct nfs
{
int i;
- if (fsloc == NULL)
- return;
-
for (i = 0; i < fsloc->locations_count; i++) {
kfree(fsloc->locations[i].path);
kfree(fsloc->locations[i].hosts);
--
1.4.2.g55c3
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
WARNING: multiple messages have this Message-ID (diff)
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Andrew Morton <akpm@osdl.org>
Cc: NeilBrown <neilb@suse.de>,
nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH 3 of 3] nfsd4: fslocs: remove spurious NULL check
Date: Mon, 2 Oct 2006 14:26:41 -0400 [thread overview]
Message-ID: <20061002182641.GE8084@fieldses.org> (raw)
In-Reply-To: <20061002182327.GB8084@fieldses.org>
It's obvious that the two callers of this function never call it with NULL.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
---
fs/nfsd/export.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
index ee7b03a..4a11092 100644
--- a/fs/nfsd/export.c
+++ b/fs/nfsd/export.c
@@ -323,9 +323,6 @@ static void nfsd4_fslocs_free(struct nfs
{
int i;
- if (fsloc == NULL)
- return;
-
for (i = 0; i < fsloc->locations_count; i++) {
kfree(fsloc->locations[i].path);
kfree(fsloc->locations[i].hosts);
--
1.4.2.g55c3
next prev parent reply other threads:[~2006-10-02 18:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 3:08 [PATCH 000 of 8] knfsd: Introduction NeilBrown
2006-09-29 3:08 ` NeilBrown
2006-09-29 3:08 ` [PATCH 001 of 8] knfsd: Add nfs-export support to tmpfs NeilBrown
2006-09-29 3:08 ` NeilBrown
2006-09-29 6:29 ` Andrew Morton
2006-09-29 6:29 ` Andrew Morton
2006-09-29 6:48 ` Neil Brown
2006-09-29 6:48 ` [NFS] " Neil Brown
2006-09-29 19:41 ` Hugh Dickins
2006-09-29 19:41 ` [NFS] " Hugh Dickins
2006-10-03 0:08 ` Neil Brown
2006-10-03 0:08 ` [NFS] " Neil Brown
2006-09-29 3:08 ` [PATCH 002 of 8] knfsd: lockd: fix refount on nsm NeilBrown
2006-09-29 3:08 ` NeilBrown
2006-09-29 6:01 ` Olaf Kirch
2006-09-29 6:01 ` [NFS] " Olaf Kirch
2006-09-29 3:08 ` [PATCH 003 of 8] knfsd: Fix auto-sizing of nfsd request/reply buffers NeilBrown
2006-09-29 3:08 ` NeilBrown
2006-09-29 3:08 ` [PATCH 004 of 8] knfsd: Close a race-opportunity in d_splice_alias NeilBrown
2006-09-29 3:08 ` NeilBrown
2006-09-29 3:09 ` [PATCH 005 of 8] knfsd: nfsd: store export path in export NeilBrown
2006-09-29 3:09 ` NeilBrown
2006-09-29 3:09 ` [PATCH 006 of 8] knfsd: nfsd4: fslocations data structures NeilBrown
2006-09-29 3:09 ` NeilBrown
2006-09-29 6:45 ` Andrew Morton
2006-09-29 6:45 ` Andrew Morton
2006-10-02 18:23 ` J. Bruce Fields
2006-10-02 18:23 ` [NFS] " J. Bruce Fields
2006-10-02 18:24 ` [PATCH 1 of 3] nfsd4: fix fs locations bounds-checking J. Bruce Fields
2006-10-02 18:24 ` J. Bruce Fields
2006-10-02 18:26 ` [PATCH 2 of 3] nfsd4: fslocs: fix compile in non-CONFIG_NFSD_V4 case J. Bruce Fields
2006-10-02 18:26 ` J. Bruce Fields
2006-10-02 18:26 ` J. Bruce Fields [this message]
2006-10-02 18:26 ` [PATCH 3 of 3] nfsd4: fslocs: remove spurious NULL check J. Bruce Fields
2006-09-29 3:09 ` [PATCH 007 of 8] knfsd: nfsd4: xdr encoding for fs_locations NeilBrown
2006-09-29 3:09 ` NeilBrown
2006-09-29 3:09 ` [PATCH 008 of 8] knfsd: nfsd4: actually use all the pieces to implement referrals NeilBrown
2006-09-29 3:09 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061002182641.GE8084@fieldses.org \
--to=bfields@fieldses.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.