From: Frederik Deweerdt <deweerdt@free.fr>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check
Date: Tue, 03 Oct 2006 08:10:22 +0000 [thread overview]
Message-ID: <20061003081022.GD2785@slug> (raw)
In-Reply-To: <20061003075607.32837.qmail@web55612.mail.re4.yahoo.com>
On Tue, Oct 03, 2006 at 12:56:07AM -0700, Amit Choudhary wrote:
> Description: Check the return value of kmalloc() in function snd_card_ad1816a_pnp(), in file sound/isa/ad1816a/ad1816a.c.
It seems that your mailer converts the tabs to white spaces, that's why
your patch cannot be applied.
Regards,
Frederik
>
> Signed-off-by: Amit Choudhary <amit2030@yahoo.com>
>
> diff --git a/sound/isa/ad1816a/ad1816a.c b/sound/isa/ad1816a/ad1816a.c
> index b33a5fb..fab77ae 100644
> --- a/sound/isa/ad1816a/ad1816a.c
> +++ b/sound/isa/ad1816a/ad1816a.c
> @@ -120,6 +120,8 @@ static int __devinit snd_card_ad1816a_pn
> struct pnp_resource_table *cfg = kmalloc(sizeof(*cfg), GFP_KERNEL);
> int err;
>
> + if(!cfg)
> + return -ENOMEM;
> acard->dev = pnp_request_card_device(card, id->devs[0].id, NULL);
> if (acard->dev = NULL) {
> kfree(cfg);
>
>
>
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/kernel-janitors
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-10-03 8:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-03 7:56 [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check kmalloc() Amit Choudhary
2006-10-03 8:10 ` Frederik Deweerdt [this message]
2006-10-03 8:13 ` [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check Amit Choudhary
2006-10-03 15:17 ` Randy Dunlap
2006-10-04 7:09 ` [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check kmalloc() Amit Choudhary
2006-10-04 7:21 ` [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check Dan Carpenter
2006-10-04 19:46 ` Amit Choudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061003081022.GD2785@slug \
--to=deweerdt@free.fr \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.