* Re: [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check
2006-10-03 7:56 [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check kmalloc() Amit Choudhary
@ 2006-10-03 8:10 ` Frederik Deweerdt
2006-10-03 8:13 ` Amit Choudhary
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Frederik Deweerdt @ 2006-10-03 8:10 UTC (permalink / raw)
To: kernel-janitors
On Tue, Oct 03, 2006 at 12:56:07AM -0700, Amit Choudhary wrote:
> Description: Check the return value of kmalloc() in function snd_card_ad1816a_pnp(), in file sound/isa/ad1816a/ad1816a.c.
It seems that your mailer converts the tabs to white spaces, that's why
your patch cannot be applied.
Regards,
Frederik
>
> Signed-off-by: Amit Choudhary <amit2030@yahoo.com>
>
> diff --git a/sound/isa/ad1816a/ad1816a.c b/sound/isa/ad1816a/ad1816a.c
> index b33a5fb..fab77ae 100644
> --- a/sound/isa/ad1816a/ad1816a.c
> +++ b/sound/isa/ad1816a/ad1816a.c
> @@ -120,6 +120,8 @@ static int __devinit snd_card_ad1816a_pn
> struct pnp_resource_table *cfg = kmalloc(sizeof(*cfg), GFP_KERNEL);
> int err;
>
> + if(!cfg)
> + return -ENOMEM;
> acard->dev = pnp_request_card_device(card, id->devs[0].id, NULL);
> if (acard->dev = NULL) {
> kfree(cfg);
>
>
>
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/kernel-janitors
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check
2006-10-03 7:56 [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check kmalloc() Amit Choudhary
2006-10-03 8:10 ` [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check Frederik Deweerdt
@ 2006-10-03 8:13 ` Amit Choudhary
2006-10-03 15:17 ` Randy Dunlap
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Amit Choudhary @ 2006-10-03 8:13 UTC (permalink / raw)
To: kernel-janitors
Yes, although it can be applied using the -l option of patch. But I will try to fix this.
--- Frederik Deweerdt <deweerdt@free.fr> wrote:
> On Tue, Oct 03, 2006 at 12:56:07AM -0700, Amit Choudhary wrote:
> > Description: Check the return value of kmalloc() in function snd_card_ad1816a_pnp(), in file
> sound/isa/ad1816a/ad1816a.c.
> It seems that your mailer converts the tabs to white spaces, that's why
> your patch cannot be applied.
> Regards,
> Frederik
> >
> > Signed-off-by: Amit Choudhary <amit2030@yahoo.com>
> >
> > diff --git a/sound/isa/ad1816a/ad1816a.c b/sound/isa/ad1816a/ad1816a.c
> > index b33a5fb..fab77ae 100644
> > --- a/sound/isa/ad1816a/ad1816a.c
> > +++ b/sound/isa/ad1816a/ad1816a.c
> > @@ -120,6 +120,8 @@ static int __devinit snd_card_ad1816a_pn
> > struct pnp_resource_table *cfg = kmalloc(sizeof(*cfg), GFP_KERNEL);
> > int err;
> >
> > + if(!cfg)
> > + return -ENOMEM;
> > acard->dev = pnp_request_card_device(card, id->devs[0].id, NULL);
> > if (acard->dev = NULL) {
> > kfree(cfg);
> >
> >
> >
> > _______________________________________________
> > Kernel-janitors mailing list
> > Kernel-janitors@lists.osdl.org
> > https://lists.osdl.org/mailman/listinfo/kernel-janitors
> >
>
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check
2006-10-03 7:56 [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check kmalloc() Amit Choudhary
2006-10-03 8:10 ` [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check Frederik Deweerdt
2006-10-03 8:13 ` Amit Choudhary
@ 2006-10-03 15:17 ` Randy Dunlap
2006-10-04 7:09 ` [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check kmalloc() Amit Choudhary
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Randy Dunlap @ 2006-10-03 15:17 UTC (permalink / raw)
To: kernel-janitors
On Tue, 3 Oct 2006 08:10:22 +0000 Frederik Deweerdt wrote:
> On Tue, Oct 03, 2006 at 12:56:07AM -0700, Amit Choudhary wrote:
> > Description: Check the return value of kmalloc() in function snd_card_ad1816a_pnp(), in file sound/isa/ad1816a/ad1816a.c.
> It seems that your mailer converts the tabs to white spaces, that's why
> your patch cannot be applied.
> Regards,
> Frederik
Please use a space after "if"....
(and after for, while, switch; but not after function names :)
> > Signed-off-by: Amit Choudhary <amit2030@yahoo.com>
> >
> > diff --git a/sound/isa/ad1816a/ad1816a.c b/sound/isa/ad1816a/ad1816a.c
> > index b33a5fb..fab77ae 100644
> > --- a/sound/isa/ad1816a/ad1816a.c
> > +++ b/sound/isa/ad1816a/ad1816a.c
> > @@ -120,6 +120,8 @@ static int __devinit snd_card_ad1816a_pn
> > struct pnp_resource_table *cfg = kmalloc(sizeof(*cfg), GFP_KERNEL);
> > int err;
> >
> > + if(!cfg)
> > + return -ENOMEM;
> > acard->dev = pnp_request_card_device(card, id->devs[0].id, NULL);
> > if (acard->dev = NULL) {
> > kfree(cfg);
---
~Randy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 7+ messages in thread* [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check kmalloc()
2006-10-03 7:56 [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check kmalloc() Amit Choudhary
` (2 preceding siblings ...)
2006-10-03 15:17 ` Randy Dunlap
@ 2006-10-04 7:09 ` Amit Choudhary
2006-10-04 7:21 ` [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check Dan Carpenter
2006-10-04 19:46 ` Amit Choudhary
5 siblings, 0 replies; 7+ messages in thread
From: Amit Choudhary @ 2006-10-04 7:09 UTC (permalink / raw)
To: kernel-janitors
Description: Check the return value of kmalloc() in function snd_card_ad1816a_pnp(), in file sound/isa/ad1816a/ad1816a.c.
Signed-off-by: Amit Choudhary <amit2030@gmail.com>
diff --git a/sound/isa/ad1816a/ad1816a.c b/sound/isa/ad1816a/ad1816a.c
index b33a5fb..16daaed 100644
--- a/sound/isa/ad1816a/ad1816a.c
+++ b/sound/isa/ad1816a/ad1816a.c
@@ -120,6 +120,8 @@ static int __devinit snd_card_ad1816a_pn
struct pnp_resource_table *cfg = kmalloc(sizeof(*cfg), GFP_KERNEL);
int err;
+ if(!cfg)
+ return -ENOMEM;
acard->dev = pnp_request_card_device(card, id->devs[0].id, NULL);
if (acard->dev = NULL) {
kfree(cfg);
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check
2006-10-03 7:56 [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check kmalloc() Amit Choudhary
` (3 preceding siblings ...)
2006-10-04 7:09 ` [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check kmalloc() Amit Choudhary
@ 2006-10-04 7:21 ` Dan Carpenter
2006-10-04 19:46 ` Amit Choudhary
5 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2006-10-04 7:21 UTC (permalink / raw)
To: kernel-janitors
On 10/4/06, Amit Choudhary <amit2030@gmail.com> wrote:
> + if(!cfg)
> + return -ENOMEM;
There is still a space missing between if and (.
Wrong:+ if(!cfg)
Correct:+ if (!cfg)
regards,
dan carpenter
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check
2006-10-03 7:56 [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check kmalloc() Amit Choudhary
` (4 preceding siblings ...)
2006-10-04 7:21 ` [KJ] [PATCH] [RESEND] sound/isa/ad1816a/ad1816a.c: check Dan Carpenter
@ 2006-10-04 19:46 ` Amit Choudhary
5 siblings, 0 replies; 7+ messages in thread
From: Amit Choudhary @ 2006-10-04 19:46 UTC (permalink / raw)
To: kernel-janitors
On 10/4/06, Dan Carpenter <error27@gmail.com> wrote:
> On 10/4/06, Amit Choudhary <amit2030@gmail.com> wrote:
>
> > + if(!cfg)
> > + return -ENOMEM;
>
> There is still a space missing between if and (.
thanks for pointing it out. my mistake. I will send again. sent the
old one by mistake. but atleast got the email client right (sylpheed)
that preserves tab spaces. thanks to randy.
>
> Wrong:+ if(!cfg)
> Correct:+ if (!cfg)
>
> regards,
> dan carpenter
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 7+ messages in thread