All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Amol Lad <amol@verismonetworks.com>,
	kernel Janitors <kernel-janitors@lists.osdl.org>,
	linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [KJ] [PATCH] drivers/char/riscom8.c:
Date: Sat, 14 Oct 2006 17:49:37 +0000	[thread overview]
Message-ID: <20061014174936.GN11633@parisc-linux.org> (raw)
In-Reply-To: <1160835602.5732.30.camel@localhost.localdomain>

On Sat, Oct 14, 2006 at 03:20:02PM +0100, Alan Cox wrote:
> 1. The irq locking isn't doing anything as the IRQ handler itself is not
> taking the lock

Looks like you reviewed the first version instead of the version Amol
sent after Arjan critiqued that.

> 2. If the irq handler itself dumbly locks to fix this then we get
> tty_flip_buffer_push() re-entering the other code paths and deadlocking
> if low latency is enabled

Yep, still a problem with the revised patch.

> 3. Some of the use of local_save/spin_lock_irq seems over-clever and
> unneeded
> 
> Fixable but how about we just delete the file since it has been broken
> for ages and nobody can be using it ?

Only broken on SMP ...

I wouldn't mind writing a new driver (using the serial core) if someone
wants to send me one.  I need a multiport serial card anyway ...
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Amol Lad <amol@verismonetworks.com>,
	kernel Janitors <kernel-janitors@lists.osdl.org>,
	linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [KJ] [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti()	removal
Date: Sat, 14 Oct 2006 11:49:37 -0600	[thread overview]
Message-ID: <20061014174936.GN11633@parisc-linux.org> (raw)
In-Reply-To: <1160835602.5732.30.camel@localhost.localdomain>

On Sat, Oct 14, 2006 at 03:20:02PM +0100, Alan Cox wrote:
> 1. The irq locking isn't doing anything as the IRQ handler itself is not
> taking the lock

Looks like you reviewed the first version instead of the version Amol
sent after Arjan critiqued that.

> 2. If the irq handler itself dumbly locks to fix this then we get
> tty_flip_buffer_push() re-entering the other code paths and deadlocking
> if low latency is enabled

Yep, still a problem with the revised patch.

> 3. Some of the use of local_save/spin_lock_irq seems over-clever and
> unneeded
> 
> Fixable but how about we just delete the file since it has been broken
> for ages and nobody can be using it ?

Only broken on SMP ...

I wouldn't mind writing a new driver (using the serial core) if someone
wants to send me one.  I need a multiport serial card anyway ...

  reply	other threads:[~2006-10-14 17:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-13 11:40 [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal Amol Lad
2006-10-13 11:52 ` [KJ] [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() Amol Lad
2006-10-13 11:56 ` [KJ] [PATCH] drivers/char/riscom8.c: Arjan van de Ven
2006-10-13 11:56   ` [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal Arjan van de Ven
2006-10-13 12:36   ` Amol Lad
2006-10-13 12:48     ` [KJ] [PATCH] drivers/char/riscom8.c: Amol Lad
2006-10-13 15:00 ` Alan Cox
2006-10-13 15:00   ` [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal Alan Cox
2006-10-14  7:39   ` Amol Lad
2006-10-14  7:51     ` [KJ] [PATCH] drivers/char/riscom8.c: Amol Lad
2006-10-14 12:18     ` Alan Cox
2006-10-14 12:18       ` [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal Alan Cox
2006-10-14 14:20 ` [KJ] [PATCH] drivers/char/riscom8.c: Alan Cox
2006-10-14 14:20   ` [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal Alan Cox
2006-10-14 17:49   ` Matthew Wilcox [this message]
2006-10-14 17:49     ` [KJ] " Matthew Wilcox
2006-10-14 18:41     ` [KJ] [PATCH] Alan Cox
2006-10-14 18:41       ` [KJ] [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal Alan Cox
2006-10-14 18:50       ` [KJ] [PATCH] drivers/char/riscom8.c: Matthew Wilcox
2006-10-14 18:50         ` [KJ] [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal Matthew Wilcox
2006-10-16  4:32   ` Amol Lad
2006-10-16  4:44     ` [KJ] [PATCH] drivers/char/riscom8.c: Amol Lad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061014174936.GN11633@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=amol@verismonetworks.com \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.