Review of revision cdf57334d92107e67da0a4fcde849921042f581a

Review of revision cdf57334d92107e67da0a4fcde849921042f581a

[Marcin Juszkiewicz]

Can someone look at revision cdf57334d92107e67da0a4fcde849921042f581a to 
check my hack?

It change one syscall in libaio 0.3.106 so aiostress or reaim can be 
built. Without this patch I was getting undefined reference 
to '__io_getevents_0_4'.

-- 
JID: hrw-jabber.org
OpenEmbedded developer/consultant

        Linux! -- Because a big world can not fit in small windows.

Re: Review of revision cdf57334d92107e67da0a4fcde849921042f581a

[Jamie Lenehan]

On Sat, Oct 14, 2006 at 10:09:30PM +0200, Marcin Juszkiewicz wrote:
> 
> Can someone look at revision cdf57334d92107e67da0a4fcde849921042f581a to 
> check my hack?

Looks wrong... you are building for arm right? With your hack and
building on i486 I get:

  | ccache i486-linux-gcc -nostdlib -nostartfiles -Wall -I. -g -fomit-frame-pointer -O2 -fPIC -c -o io_getevents.ol io_getevents.c
  | io_getevents.c:43: error: redefinition of ‘io_getevents_0_4’
  | io_getevents.c:25: error: previous definition of ‘io_getevents_0_4’ was here
  | make[1]: *** [io_getevents.ol] Error 1
  | make[1]: Leaving directory /data/oe/build/wrap-glibc/tmp/work/libaio-0.3.106-r1/libaio-0.3.106/src'

I think the real problem is a typo in syscall-arm.h

--- libaio-0.3.106/src/syscall-arm.h	2006/10/15 01:02:35	1.1
+++ libaio-0.3.106/src/syscall-arm.h	2006/10/15 01:02:43
@@ -97,7 +97,7 @@
 }
 
 #define io_syscall5(type,fname,sname,type1,arg1,type2,arg2,type3,arg3,type4,arg4,type5,arg5)	\
-type ffname(type1 arg1, type2 arg2, type3 arg3, type4 arg4, type5 arg5) {\
+type fname(type1 arg1, type2 arg2, type3 arg3, type4 arg4, type5 arg5) {\
   __SYS_REG(sname)							\
   register long __r0 __asm__("r0") = (long)arg1;			\
   register long __r1 __asm__("r1") = (long)arg2;			\

This file is added by 00_arches.patch. So updating that patch with
the one line change above should be enough.

-- 
 Jamie Lenehan <lenehan@twibble.org>

Re: Review of revision cdf57334d92107e67da0a4fcde849921042f581a

[Marcin Juszkiewicz]

Dnia niedziela, 15 października 2006 03:07, Jamie Lenehan napisał:
> On Sat, Oct 14, 2006 at 10:09:30PM +0200, Marcin Juszkiewicz wrote:

> > Can someone look at revision cdf57334d92107e67da0a4fcde849921042f581a
> > to check my hack?
>
> Looks wrong... you are building for arm right? With your hack and
> building on i486 I get:

>   | io_getevents.c:25: error: previous definition of ‘io_getevents_0_4’

> I think the real problem is a typo in syscall-arm.h

> This file is added by 00_arches.patch. So updating that patch with
> the one line change above should be enough.

Thx - pushed fix into .dev tree. I will also notify Debian maintainer 
about this (patch was taken from Debian).

-- 
JID: hrw-jabber.org
OpenEmbedded developer/consultant

                 A dream to some... A nightmare to others!
                 		-- Merlin