From: Adrian Bunk <bunk@stusta.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [2.6 patch] fs/gfs2/dir.c:gfs2_dir_write_data(): remove dead code
Date: Thu, 19 Oct 2006 15:12:24 +0200 [thread overview]
Message-ID: <20061019131224.GL3502@stusta.de> (raw)
The Coverity checker spotted this obviously dead code.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6/fs/gfs2/dir.c.old 2006-10-19 01:07:42.000000000 +0200
+++ linux-2.6/fs/gfs2/dir.c 2006-10-19 01:07:49.000000000 +0200
@@ -209,14 +209,12 @@ static int gfs2_dir_write_data(struct gf
if (error)
goto fail;
gfs2_trans_add_bh(ip->i_gl, bh, 1);
memcpy(bh->b_data + o, buf, amount);
brelse(bh);
- if (error)
- goto fail;
buf += amount;
copied += amount;
lblock++;
dblock++;
extlen--;
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: swhiteho@redhat.com
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: [2.6 patch] fs/gfs2/dir.c:gfs2_dir_write_data(): remove dead code
Date: Thu, 19 Oct 2006 15:12:24 +0200 [thread overview]
Message-ID: <20061019131224.GL3502@stusta.de> (raw)
The Coverity checker spotted this obviously dead code.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6/fs/gfs2/dir.c.old 2006-10-19 01:07:42.000000000 +0200
+++ linux-2.6/fs/gfs2/dir.c 2006-10-19 01:07:49.000000000 +0200
@@ -209,14 +209,12 @@ static int gfs2_dir_write_data(struct gf
if (error)
goto fail;
gfs2_trans_add_bh(ip->i_gl, bh, 1);
memcpy(bh->b_data + o, buf, amount);
brelse(bh);
- if (error)
- goto fail;
buf += amount;
copied += amount;
lblock++;
dblock++;
extlen--;
next reply other threads:[~2006-10-19 13:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 13:12 Adrian Bunk [this message]
2006-10-19 13:12 ` [2.6 patch] fs/gfs2/dir.c:gfs2_dir_write_data(): remove dead code Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061019131224.GL3502@stusta.de \
--to=bunk@stusta.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.