* [Cluster-devel] [2.6 patch] fs/gfs2/dir.c:gfs2_dir_write_data(): remove dead code
@ 2006-10-19 13:12 ` Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2006-10-19 13:12 UTC (permalink / raw)
To: cluster-devel.redhat.com
The Coverity checker spotted this obviously dead code.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6/fs/gfs2/dir.c.old 2006-10-19 01:07:42.000000000 +0200
+++ linux-2.6/fs/gfs2/dir.c 2006-10-19 01:07:49.000000000 +0200
@@ -209,14 +209,12 @@ static int gfs2_dir_write_data(struct gf
if (error)
goto fail;
gfs2_trans_add_bh(ip->i_gl, bh, 1);
memcpy(bh->b_data + o, buf, amount);
brelse(bh);
- if (error)
- goto fail;
buf += amount;
copied += amount;
lblock++;
dblock++;
extlen--;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [2.6 patch] fs/gfs2/dir.c:gfs2_dir_write_data(): remove dead code
@ 2006-10-19 13:12 ` Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2006-10-19 13:12 UTC (permalink / raw)
To: swhiteho; +Cc: cluster-devel, linux-kernel
The Coverity checker spotted this obviously dead code.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6/fs/gfs2/dir.c.old 2006-10-19 01:07:42.000000000 +0200
+++ linux-2.6/fs/gfs2/dir.c 2006-10-19 01:07:49.000000000 +0200
@@ -209,14 +209,12 @@ static int gfs2_dir_write_data(struct gf
if (error)
goto fail;
gfs2_trans_add_bh(ip->i_gl, bh, 1);
memcpy(bh->b_data + o, buf, amount);
brelse(bh);
- if (error)
- goto fail;
buf += amount;
copied += amount;
lblock++;
dblock++;
extlen--;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-19 13:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-19 13:12 [Cluster-devel] [2.6 patch] fs/gfs2/dir.c:gfs2_dir_write_data(): remove dead code Adrian Bunk
2006-10-19 13:12 ` Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.