[U-Boot-Users] ixdp 465

[U-Boot-Users] ixdp 465

[Michael Trimarchi]

Hi all,
I have add support for ixdp 465, and I'd like to post a patch when I 
clean the code. Is it possible?

Regards Michael

[U-Boot-Users] ixdp 465

[Stefan Roese]

Hi Michael,

On Tuesday 10 October 2006 19:04, Michael Trimarchi wrote:
> I have add support for ixdp 465, and I'd like to post a patch when I
> clean the code. Is it possible?

Yes of course. Please take a look at the README in the sections:

"Coding Standards:", "Submitting Patches:" and "Notes:"

for more details.

And from bad experience with the IXP4xx, please make sure that you don't 
include files with licensing problems (e.g. Intel Proprietary License).

Thanks.

Best regards,
Stefan

[U-Boot-Users] ixdp 465

[Michael Trimarchi]

Stefan Roese wrote:

> Hi Michael,
>
> On Tuesday 10 October 2006 19:04, Michael Trimarchi wrote:
>  
>
>> I have add support for ixdp 465, and I'd like to post a patch when I
>> clean the code. Is it possible?
>>   
>
>
> Yes of course. Please take a look at the README in the sections:
>
> "Coding Standards:", "Submitting Patches:" and "Notes:"
>
> for more details.
>
> And from bad experience with the IXP4xx, please make sure that you 
> don't include files with licensing problems (e.g. Intel Proprietary 
> License).
>
> Thanks.
>
> Best regards,
> Stefan
>
>  
>
Ok,
I dosen't integrate the Intel support for npe ethernet card but just 
support the memory initialization and the flash support. I know that is 
not complete but if the user want the intel support, he can patch the 
kernel with the intel acccess library.

Regards Michael

[U-Boot-Users] ixdp 465

[Stefan Roese]

Hi Michael,

On Thursday 19 October 2006 20:27, Michael Trimarchi wrote:
> This is a preliminary version of ixdp465 patch for u-boot. I hope that
> it can be useful, let me know. I know that it is not too clean, if I
> have the time I will make it better.

Just one short remarks for your cleanup: Please use the common cfi flash 
driver for flash's that are CFI compliant.

Best regards,
Stefan

[U-Boot-Users] ixdp 465

[Michael Trimarchi]

Hi,
Stefan Roese wrote:

>Hi Michael,
>
>On Thursday 19 October 2006 20:27, Michael Trimarchi wrote:
>  
>
>>This is a preliminary version of ixdp465 patch for u-boot. I hope that
>>it can be useful, let me know. I know that it is not too clean, if I
>>have the time I will make it better.
>>    
>>
>
>Just one short remarks for your cleanup: Please use the common cfi flash 
>driver for flash's that are CFI compliant.
>
Ok


>  
>
Regards Michael

[U-Boot-Users] ixdp 465

[Wolfgang Denk]

Dear Michael,

in message <453877C8.10103@evidence.eu.com> you wrote:
> >
> >Ummm... which patch are you referring to?

Areghhh. Please NEVER send patches to my address. Always send these
through the mailing list only, so others can comment on these, too.

> diff -raN u-boot-1.1.4.orig/Makefile u-boot-1.1.4/Makefile
> 1614a1615,1617
> > ixdp465_config : unconfig
> > 	@./mkconfig $(@:_config=) arm ixp ixdp465
> > 

Such a plain diff output is not a patch, it cannot be applied. Please
make sure to read the README, section Submitting  Patches.  You  MUST
use the correct options when creating the patch.

Also mind the size limitations on the mailing list.

And make sure to stick  to  the  required  coding  style,  your  code
contains lots of problems (indentation by spaces instead of TABs, C++
comments, trailing white space, etc.).

Also never add change log entires to any files. We use git for this
purpose.

Make sure your code does not contain dead code (#if 0 etc.).



Please cleanup and resubmit.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I'm a programmer: I don't buy software, I write it.
                                                  -- Tom Christiansen

[U-Boot-Users] ixdp 465

[Michael Trimarchi]

Hi,
Wolfgang Denk wrote:

>Such a plain diff output is not a patch, it cannot be applied. Please
>make sure to read the README, section Submitting  Patches.  You  MUST
>use the correct options when creating the patch.
>
Ok, some people ask me for a patch because they need it. I will produce 
a better patch.

>
>Also mind the size limitations on the mailing list.
>
>And make sure to stick  to  the  required  coding  style,  your  code
>contains lots of problems (indentation by spaces instead of TABs, C++
>comments, trailing white space, etc.).
>
thank's,
I'm going to fix

>
>Also never add change log entires to any files. We use git for this
>purpose.
>
Ok

>
>Make sure your code does not contain dead code (#if 0 etc.).
>
The dead code is already present,  I just add my code, without dead 
code. Thank's a lot for your comment

>
>
>
>Please cleanup and resubmit.
>
>Best regards,
>
>Wolfgang Denk
>  
>
Regards Michael