From: Matthew Wilcox <matthew@wil.cx>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
akpm@osdl.org, kernel-janitors@lists.osdl.org, maxk@qualcomm.com,
kjhall@us.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [KJ] [PATCH] Correct misc_register return code handling in
Date: Tue, 24 Oct 2006 13:24:37 +0000 [thread overview]
Message-ID: <20061024132437.GP25210@parisc-linux.org> (raw)
In-Reply-To: <20061024125306.GA1608@hmsreliant.homelinux.net>
On Tue, Oct 24, 2006 at 08:53:06AM -0400, Neil Horman wrote:
> The INIT_LIST_HEAD is there to prevent a potential oops on module removal.
> misc_register, if it fails, leaves miscdevice.list unchanged. That means its
> next and prev pointers contain NULL or garbage, when both pointers should contain
> &miscdevice.list. If we don't do that, then there is a chance we will oops on
> module removal when we do a list_del in misc_deregister on the moudule_exit
> routine. I could have done this statically, but I thought it looked cleaner to
> do it with the macro in the code.
Maybe it would be better to have misc_register() call INIT_LIST_HEAD in
the failure case?
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
akpm@osdl.org, kernel-janitors@lists.osdl.org, maxk@qualcomm.com,
kjhall@us.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [KJ] [PATCH] Correct misc_register return code handling in several drivers
Date: Tue, 24 Oct 2006 07:24:37 -0600 [thread overview]
Message-ID: <20061024132437.GP25210@parisc-linux.org> (raw)
In-Reply-To: <20061024125306.GA1608@hmsreliant.homelinux.net>
On Tue, Oct 24, 2006 at 08:53:06AM -0400, Neil Horman wrote:
> The INIT_LIST_HEAD is there to prevent a potential oops on module removal.
> misc_register, if it fails, leaves miscdevice.list unchanged. That means its
> next and prev pointers contain NULL or garbage, when both pointers should contain
> &miscdevice.list. If we don't do that, then there is a chance we will oops on
> module removal when we do a list_del in misc_deregister on the moudule_exit
> routine. I could have done this statically, but I thought it looked cleaner to
> do it with the macro in the code.
Maybe it would be better to have misc_register() call INIT_LIST_HEAD in
the failure case?
next prev parent reply other threads:[~2006-10-24 13:24 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 17:19 [KJ] [PATCH] Correct misc_register return code handling in several Neil Horman
2006-10-23 17:19 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-10-23 17:39 ` [KJ] [PATCH] Correct misc_register return code handling Alan Cox
2006-10-23 17:39 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Alan Cox
2006-10-23 17:54 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-10-23 17:54 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-10-23 18:23 ` [KJ] [PATCH] Correct misc_register return code handling Kylene Jo Hall
2006-10-23 18:23 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Kylene Jo Hall
2006-10-23 19:18 ` [KJ] [PATCH] Correct misc_register return code handling Alan Cox
2006-10-23 19:18 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Alan Cox
2006-10-23 18:01 ` [KJ] [PATCH] Correct misc_register return code handling in Dan Carpenter
2006-10-23 18:01 ` [KJ] [PATCH] Correct misc_register return code handling in several drivers Dan Carpenter
2006-10-23 18:13 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-10-23 18:13 ` [KJ] [PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-10-23 18:32 ` [KJ] [PATCH] Correct misc_register return code handling in Dan Carpenter
2006-10-23 18:32 ` [KJ] [PATCH] Correct misc_register return code handling in several drivers Dan Carpenter
2006-10-23 18:44 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-10-23 18:44 ` [KJ] [PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-10-23 19:42 ` [KJ] [PATCH] Correct misc_register return code handling in Håkon Løvdal
2006-10-24 3:34 ` [KJ] [PATCH] Correct misc_register return code handling Benjamin Herrenschmidt
2006-10-24 3:34 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Benjamin Herrenschmidt
2006-10-24 12:53 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-10-24 12:53 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-10-24 13:24 ` Matthew Wilcox [this message]
2006-10-24 13:24 ` [KJ] [PATCH] " Matthew Wilcox
2006-10-24 15:07 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-10-24 15:07 ` [KJ] [PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-10-24 22:42 ` [KJ] [PATCH] Correct misc_register return code handling Benjamin Herrenschmidt
2006-10-24 22:42 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Benjamin Herrenschmidt
2006-10-25 13:17 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-10-25 13:17 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-11-01 13:56 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-11-01 13:56 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-11-01 23:55 ` [KJ] [PATCH] Correct misc_register return code handling in Andrew Morton
2006-11-01 23:55 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Andrew Morton
2006-11-02 14:21 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-11-02 14:21 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-11-02 0:05 ` [KJ] [PATCH] Correct misc_register return code handling in Jesper Juhl
2006-11-02 0:05 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Jesper Juhl
2006-11-02 0:11 ` [KJ] [PATCH] Correct misc_register return code handling in Randy Dunlap
2006-11-02 0:11 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Randy Dunlap
2006-11-02 0:24 ` [KJ] [PATCH] Correct misc_register return code handling in Jesper Juhl
2006-11-02 0:24 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Jesper Juhl
2006-11-02 0:27 ` [KJ] [PATCH] Correct misc_register return code handling in Andrew Morton
2006-11-02 0:27 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Andrew Morton
2006-11-02 0:44 ` [KJ] [PATCH] Correct misc_register return code handling in Jesper Juhl
2006-11-02 0:44 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Jesper Juhl
2006-11-02 1:12 ` [KJ] [PATCH] Correct misc_register return code handling in Randy Dunlap
2006-11-02 1:12 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Randy Dunlap
2006-11-02 1:23 ` [KJ] [PATCH] Correct misc_register return code handling in Jesper Juhl
2006-11-02 1:23 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Jesper Juhl
2006-11-02 1:22 ` [KJ] [PATCH] Correct misc_register return code handling in Randy Dunlap
2006-11-02 1:22 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Randy Dunlap
2006-11-15 0:04 ` [KJ] [PATCH] Correct misc_register return code handling in Randy Dunlap
2006-11-15 0:04 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Randy Dunlap
2006-11-15 9:05 ` [KJ] [PATCH] Correct misc_register return code handling in Jesper Juhl
2006-11-15 9:05 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061024132437.GP25210@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.