From: Andrew Morton <akpm@osdl.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Jesper Juhl <jesper.juhl@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
kernel-janitors@lists.osdl.org, kjhall@us.ibm.com,
maxk@qualcomm.com, linux-kernel@vger.kernel.org
Subject: Re: [KJ] [PATCH] Correct misc_register return code handling in
Date: Thu, 02 Nov 2006 00:27:27 +0000 [thread overview]
Message-ID: <20061101162727.72f1183b.akpm@osdl.org> (raw)
In-Reply-To: <20061101161155.d7b30258.randy.dunlap@oracle.com>
On Wed, 1 Nov 2006 16:11:55 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > Hmm, I guess that should be defined once and for all in
> > Documentation/CodingStyle
>
> I have some other CodingStyle changes to submit, but feel free
> to write this one up.
Starting labels in column 2 gives me the creeps, personally. But there's a
decent justification for it.
> However, I didn't know that we had a known style for this, other
> than "not indented so far that it's hidden".
>
> If a label in column 0 [0-based :] confuses patch, then that's
> a reason, I suppose. I wasn't aware of that one...
> In a case like that, we usually say "fix the tool then."
The problem is that `diff -p' screws up and displays the label: in the
place where it should be displaying the function name.
Of course, lots of people forget the -p anyway... Maybe we can fix those
tools ;)
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@osdl.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: "Jesper Juhl" <jesper.juhl@gmail.com>,
"Neil Horman" <nhorman@tuxdriver.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
kernel-janitors@lists.osdl.org, kjhall@us.ibm.com,
maxk@qualcomm.com, linux-kernel@vger.kernel.org
Subject: Re: [KJ][PATCH] Correct misc_register return code handling in several drivers
Date: Wed, 1 Nov 2006 16:27:27 -0800 [thread overview]
Message-ID: <20061101162727.72f1183b.akpm@osdl.org> (raw)
In-Reply-To: <20061101161155.d7b30258.randy.dunlap@oracle.com>
On Wed, 1 Nov 2006 16:11:55 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > Hmm, I guess that should be defined once and for all in
> > Documentation/CodingStyle
>
> I have some other CodingStyle changes to submit, but feel free
> to write this one up.
Starting labels in column 2 gives me the creeps, personally. But there's a
decent justification for it.
> However, I didn't know that we had a known style for this, other
> than "not indented so far that it's hidden".
>
> If a label in column 0 [0-based :] confuses patch, then that's
> a reason, I suppose. I wasn't aware of that one...
> In a case like that, we usually say "fix the tool then."
The problem is that `diff -p' screws up and displays the label: in the
place where it should be displaying the function name.
Of course, lots of people forget the -p anyway... Maybe we can fix those
tools ;)
next prev parent reply other threads:[~2006-11-02 0:27 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 17:19 [KJ] [PATCH] Correct misc_register return code handling in several Neil Horman
2006-10-23 17:19 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-10-23 17:39 ` [KJ] [PATCH] Correct misc_register return code handling Alan Cox
2006-10-23 17:39 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Alan Cox
2006-10-23 17:54 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-10-23 17:54 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-10-23 18:23 ` [KJ] [PATCH] Correct misc_register return code handling Kylene Jo Hall
2006-10-23 18:23 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Kylene Jo Hall
2006-10-23 19:18 ` [KJ] [PATCH] Correct misc_register return code handling Alan Cox
2006-10-23 19:18 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Alan Cox
2006-10-23 18:01 ` [KJ] [PATCH] Correct misc_register return code handling in Dan Carpenter
2006-10-23 18:01 ` [KJ] [PATCH] Correct misc_register return code handling in several drivers Dan Carpenter
2006-10-23 18:13 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-10-23 18:13 ` [KJ] [PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-10-23 18:32 ` [KJ] [PATCH] Correct misc_register return code handling in Dan Carpenter
2006-10-23 18:32 ` [KJ] [PATCH] Correct misc_register return code handling in several drivers Dan Carpenter
2006-10-23 18:44 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-10-23 18:44 ` [KJ] [PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-10-23 19:42 ` [KJ] [PATCH] Correct misc_register return code handling in Håkon Løvdal
2006-10-24 3:34 ` [KJ] [PATCH] Correct misc_register return code handling Benjamin Herrenschmidt
2006-10-24 3:34 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Benjamin Herrenschmidt
2006-10-24 12:53 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-10-24 12:53 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-10-24 13:24 ` [KJ] [PATCH] Correct misc_register return code handling in Matthew Wilcox
2006-10-24 13:24 ` [KJ] [PATCH] Correct misc_register return code handling in several drivers Matthew Wilcox
2006-10-24 15:07 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-10-24 15:07 ` [KJ] [PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-10-24 22:42 ` [KJ] [PATCH] Correct misc_register return code handling Benjamin Herrenschmidt
2006-10-24 22:42 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Benjamin Herrenschmidt
2006-10-25 13:17 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-10-25 13:17 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-11-01 13:56 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-11-01 13:56 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-11-01 23:55 ` [KJ] [PATCH] Correct misc_register return code handling in Andrew Morton
2006-11-01 23:55 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Andrew Morton
2006-11-02 14:21 ` [KJ] [PATCH] Correct misc_register return code handling in Neil Horman
2006-11-02 14:21 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Neil Horman
2006-11-02 0:05 ` [KJ] [PATCH] Correct misc_register return code handling in Jesper Juhl
2006-11-02 0:05 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Jesper Juhl
2006-11-02 0:11 ` [KJ] [PATCH] Correct misc_register return code handling in Randy Dunlap
2006-11-02 0:11 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Randy Dunlap
2006-11-02 0:24 ` [KJ] [PATCH] Correct misc_register return code handling in Jesper Juhl
2006-11-02 0:24 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Jesper Juhl
2006-11-02 0:27 ` Andrew Morton [this message]
2006-11-02 0:27 ` Andrew Morton
2006-11-02 0:44 ` [KJ] [PATCH] Correct misc_register return code handling in Jesper Juhl
2006-11-02 0:44 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Jesper Juhl
2006-11-02 1:12 ` [KJ] [PATCH] Correct misc_register return code handling in Randy Dunlap
2006-11-02 1:12 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Randy Dunlap
2006-11-02 1:23 ` [KJ] [PATCH] Correct misc_register return code handling in Jesper Juhl
2006-11-02 1:23 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Jesper Juhl
2006-11-02 1:22 ` [KJ] [PATCH] Correct misc_register return code handling in Randy Dunlap
2006-11-02 1:22 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Randy Dunlap
2006-11-15 0:04 ` [KJ] [PATCH] Correct misc_register return code handling in Randy Dunlap
2006-11-15 0:04 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Randy Dunlap
2006-11-15 9:05 ` [KJ] [PATCH] Correct misc_register return code handling in Jesper Juhl
2006-11-15 9:05 ` [KJ][PATCH] Correct misc_register return code handling in several drivers Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061101162727.72f1183b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=jesper.juhl@gmail.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=kjhall@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=nhorman@tuxdriver.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.