From: Al Viro <viro@ftp.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: kenneth.w.chen@intel.com, akpm@osdl.org, jgarzik@pobox.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [patch] fix up generic csum_ipv6_magic function prototype
Date: Thu, 9 Nov 2006 07:22:16 +0000 [thread overview]
Message-ID: <20061109072216.GL29920@ftp.linux.org.uk> (raw)
In-Reply-To: <20061108.230059.57444310.davem@davemloft.net>
On Wed, Nov 08, 2006 at 11:00:59PM -0800, David Miller wrote:
> From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
> Date: Wed, 8 Nov 2006 18:02:06 -0800
>
> > The generic version of csum_ipv6_magic has the len argument declared as
> > __u16, while most arch dependent version declare it as __u32. After
> > looking at the call site of this function, I come up to a conclusion
> > that __u32 is a better match with the actual usage.
> >
> > Hence, patch to change argument type for greater consistency.
> >
> > Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
>
> Architecture implementations such as the ones for m32r and parisc have
> the same problem, so "for consistency" please fix them up as well.
>
> Thanks a lot.
Please, hold. One of the patches in my queue gets sanitized prototypes
for all that stuff and it'll conflict like crazy.
I haven't touch that argument yet; if there's an agreement as to what should
we switch to, I'll do that. So... does everyone agree that u32 is the way
to go?
next prev parent reply other threads:[~2006-11-09 7:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 2:02 [patch] fix up generic csum_ipv6_magic function prototype Chen, Kenneth W
2006-11-09 7:00 ` David Miller
2006-11-09 7:22 ` Al Viro [this message]
2006-11-09 7:55 ` David Miller
2006-11-13 8:52 ` Al Viro
2006-11-13 9:12 ` Russell King
2006-11-13 9:25 ` Al Viro
2006-11-13 9:37 ` Andi Kleen
2006-11-14 0:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061109072216.GL29920@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.