From: Andi Kleen <ak@suse.de>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: kenneth.w.chen@intel.com, akpm@osdl.org, jgarzik@pobox.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [patch] fix up generic csum_ipv6_magic function prototype
Date: 13 Nov 2006 10:37:03 +0100 [thread overview]
Message-ID: <p73y7qf3cxs.fsf@bingen.suse.de> (raw)
In-Reply-To: <20061113085223.GR29920@ftp.linux.org.uk>
Al Viro <viro@ftp.linux.org.uk> writes:
>
> Incidentally, WTF is
> define SK_CS_CALCULATE_CHECKSUM
> #ifndef CONFIG_X86_64
> #define SkCsCalculateChecksum(p,l) ((~ip_compute_csum(p, l)) & 0xffff)
> #else
> #define SkCsCalculateChecksum(p,l) ((~ip_fast_csum(p, l)) & 0xffff)
> #endif
> in ./drivers/net/sk98lin/h/skdrv1st.h?
Looks totally bogus. The x86-64 ip_fast_csum is practically identical
to the i386 version. Someone must have been asleep while reviewing
that code.
But AFAIK sk98lin is scheduled for deletion anyways, to be replaced by
sky*. Probably for good reasons. Hopefully soon.
-Andi
next prev parent reply other threads:[~2006-11-13 9:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 2:02 [patch] fix up generic csum_ipv6_magic function prototype Chen, Kenneth W
2006-11-09 7:00 ` David Miller
2006-11-09 7:22 ` Al Viro
2006-11-09 7:55 ` David Miller
2006-11-13 8:52 ` Al Viro
2006-11-13 9:12 ` Russell King
2006-11-13 9:25 ` Al Viro
2006-11-13 9:37 ` Andi Kleen [this message]
2006-11-14 0:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73y7qf3cxs.fsf@bingen.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.