From: Arnd Bergmann <arnd@arndb.de>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [kvm-devel] [PATCH] KVM: Avoid using vmx instruction directly
Date: Thu, 9 Nov 2006 15:42:30 +0100 [thread overview]
Message-ID: <200611091542.31101.arnd@arndb.de> (raw)
In-Reply-To: <45532EE3.4000104@qumranet.com>
On Thursday 09 November 2006 14:36, Avi Kivity wrote:
>
> >
> > I'm not an expert on inline assembly, but don't you need an extra
> > '"m" (phys_addr)' to make sure that gcc actually puts the variable
> > on the stack instead of passing a NULL pointer as '"a"(&phys_addr)'?
>
> Taking a variable's address should force its contents into memory (like
> calling an uninlined function with &var).
No it doesn't. You're not telling gcc that the inline assembly cares
about the contents of the variable, so it could be a reference to
a stack slot while the contents are still in a register. Or gcc
might move the assignment of phys_addr to after the inline assembly.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
akpm-3NddpPZAyC0@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] KVM: Avoid using vmx instruction directly
Date: Thu, 9 Nov 2006 15:42:30 +0100 [thread overview]
Message-ID: <200611091542.31101.arnd@arndb.de> (raw)
In-Reply-To: <45532EE3.4000104-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
On Thursday 09 November 2006 14:36, Avi Kivity wrote:
>
> >
> > I'm not an expert on inline assembly, but don't you need an extra
> > '"m" (phys_addr)' to make sure that gcc actually puts the variable
> > on the stack instead of passing a NULL pointer as '"a"(&phys_addr)'?
>
> Taking a variable's address should force its contents into memory (like
> calling an uninlined function with &var).
No it doesn't. You're not telling gcc that the inline assembly cares
about the contents of the variable, so it could be a reference to
a stack slot while the contents are still in a register. Or gcc
might move the assignment of phys_addr to after the inline assembly.
Arnd <><
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
next prev parent reply other threads:[~2006-11-09 14:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 11:08 [PATCH] KVM: Avoid using vmx instruction directly Avi Kivity
2006-11-09 11:08 ` Avi Kivity
2006-11-09 13:29 ` [kvm-devel] " Arnd Bergmann
2006-11-09 13:29 ` Arnd Bergmann
2006-11-09 13:36 ` [kvm-devel] " Avi Kivity
2006-11-09 13:36 ` Avi Kivity
2006-11-09 14:42 ` Arnd Bergmann [this message]
2006-11-09 14:42 ` Arnd Bergmann
2006-11-09 14:52 ` [kvm-devel] " Avi Kivity
2006-11-09 16:37 ` Arnd Bergmann
2006-11-09 16:51 ` Avi Kivity
2006-11-09 23:39 ` Jeremy Fitzhardinge
2006-11-10 12:46 ` Martin Schwidefsky
2006-11-10 19:38 ` Jeremy Fitzhardinge
2006-11-10 19:38 ` Jeremy Fitzhardinge
2006-11-21 18:35 ` [kvm-devel] " H. Peter Anvin
2006-11-21 18:35 ` H. Peter Anvin
2006-11-21 19:41 ` [kvm-devel] " Avi Kivity
2006-11-21 19:41 ` Avi Kivity
2006-11-21 20:50 ` [kvm-devel] " Jeremy Fitzhardinge
2006-11-21 20:50 ` Jeremy Fitzhardinge
2006-11-22 6:42 ` [kvm-devel] " Avi Kivity
2006-11-22 6:42 ` Avi Kivity
2006-11-22 9:10 ` [kvm-devel] " Jeremy Fitzhardinge
2006-11-22 9:10 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611091542.31101.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@osdl.org \
--cc=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.