From: Christoph Hellwig <hch@infradead.org>
To: Avi Kivity <avi@qumranet.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
kvm-devel@lists.sourceforge.net, akpm@osdl.org,
linux-kernel@vger.kernel.org, uril@qumranet.com
Subject: Re: [kvm-devel] [PATCH 3/3] KVM: Expose MSRs to userspace
Date: Fri, 17 Nov 2006 08:06:02 +0000 [thread overview]
Message-ID: <20061117080602.GA32211@infradead.org> (raw)
In-Reply-To: <455CB93E.4090309@qumranet.com>
On Thu, Nov 16, 2006 at 09:17:18PM +0200, Avi Kivity wrote:
> Heh. That was the original implementation by Uri. I felt that was
> wrong because _IOW() encodes the size in the ioctl number, bit the
> actual size is different.
That really shouldn't be a problem. After all the pointer approach
doesn't encode the transfered size either. Given that the variable
sized array gives a much cleaner interface you should use it.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
akpm-3NddpPZAyC0@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
uril-atKUWr5tajBWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH 3/3] KVM: Expose MSRs to userspace
Date: Fri, 17 Nov 2006 08:06:02 +0000 [thread overview]
Message-ID: <20061117080602.GA32211@infradead.org> (raw)
In-Reply-To: <455CB93E.4090309-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
On Thu, Nov 16, 2006 at 09:17:18PM +0200, Avi Kivity wrote:
> Heh. That was the original implementation by Uri. I felt that was
> wrong because _IOW() encodes the size in the ioctl number, bit the
> actual size is different.
That really shouldn't be a problem. After all the pointer approach
doesn't encode the transfered size either. Given that the variable
sized array gives a much cleaner interface you should use it.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
next prev parent reply other threads:[~2006-11-17 8:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 17:59 [PATCH 0/3] KVM: Save/resume support Avi Kivity
2006-11-16 17:59 ` Avi Kivity
2006-11-16 18:02 ` [PATCH 1/3] KVM: Expose interrupt bitmap Avi Kivity
2006-11-16 18:02 ` Avi Kivity
2006-11-16 18:03 ` [PATCH 2/3] KVM: Add time stamp counter msr and accessors Avi Kivity
2006-11-16 18:03 ` Avi Kivity
2006-11-16 18:04 ` [PATCH 3/3] KVM: Expose MSRs to userspace Avi Kivity
2006-11-16 18:04 ` Avi Kivity
2006-11-16 19:08 ` [kvm-devel] " Arnd Bergmann
2006-11-16 19:08 ` Arnd Bergmann
2006-11-16 19:17 ` [kvm-devel] " Avi Kivity
2006-11-17 8:06 ` Christoph Hellwig [this message]
2006-11-17 8:06 ` Christoph Hellwig
2006-11-17 1:02 ` Andrew Morton
2006-11-17 7:20 ` Avi Kivity
2006-11-17 7:20 ` Avi Kivity
2006-11-17 8:15 ` Andrew Morton
2006-11-17 8:15 ` Andrew Morton
2006-11-17 8:17 ` Avi Kivity
2006-11-17 8:17 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061117080602.GA32211@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=arnd@arndb.de \
--cc=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=uril@qumranet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.