From: Avi Kivity <avi@qumranet.com>
To: Andrew Morton <akpm@osdl.org>
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
uril@qumranet.com
Subject: Re: [PATCH 3/3] KVM: Expose MSRs to userspace
Date: Fri, 17 Nov 2006 10:17:56 +0200 [thread overview]
Message-ID: <455D7034.1070503@qumranet.com> (raw)
In-Reply-To: <20061117001510.58f01b3c.akpm@osdl.org>
Andrew Morton wrote:
> On Fri, 17 Nov 2006 09:20:49 +0200
> Avi Kivity <avi@qumranet.com> wrote:
>
>
>>>> +out_vcpu:
>>>> + vcpu_put(vcpu);
>>>> +
>>>> + return rc;
>>>> +}
>>>>
>>>>
>>> This function returns no indication of how many msrs it actually did set.
>>> Should it?
>>>
>>>
>> It can't hurt. Is returning the number of msrs set in the return code
>> (ala short write) acceptable, or do I need to make this a read/write ioctl?
>>
>>
>
> I'd have thought that you'd just copy the number written into msrs->nmsrs via
>
> msrs->nmsrs = num_entries;
>
> like kvm_dev_ioctl_set_msrs() does. Dunno...
>
It means making it an _IOWR() ioctl, but no matter.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
uril-atKUWr5tajBWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH 3/3] KVM: Expose MSRs to userspace
Date: Fri, 17 Nov 2006 10:17:56 +0200 [thread overview]
Message-ID: <455D7034.1070503@qumranet.com> (raw)
In-Reply-To: <20061117001510.58f01b3c.akpm-3NddpPZAyC0@public.gmane.org>
Andrew Morton wrote:
> On Fri, 17 Nov 2006 09:20:49 +0200
> Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
>
>
>>>> +out_vcpu:
>>>> + vcpu_put(vcpu);
>>>> +
>>>> + return rc;
>>>> +}
>>>>
>>>>
>>> This function returns no indication of how many msrs it actually did set.
>>> Should it?
>>>
>>>
>> It can't hurt. Is returning the number of msrs set in the return code
>> (ala short write) acceptable, or do I need to make this a read/write ioctl?
>>
>>
>
> I'd have thought that you'd just copy the number written into msrs->nmsrs via
>
> msrs->nmsrs = num_entries;
>
> like kvm_dev_ioctl_set_msrs() does. Dunno...
>
It means making it an _IOWR() ioctl, but no matter.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
next prev parent reply other threads:[~2006-11-17 8:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 17:59 [PATCH 0/3] KVM: Save/resume support Avi Kivity
2006-11-16 17:59 ` Avi Kivity
2006-11-16 18:02 ` [PATCH 1/3] KVM: Expose interrupt bitmap Avi Kivity
2006-11-16 18:02 ` Avi Kivity
2006-11-16 18:03 ` [PATCH 2/3] KVM: Add time stamp counter msr and accessors Avi Kivity
2006-11-16 18:03 ` Avi Kivity
2006-11-16 18:04 ` [PATCH 3/3] KVM: Expose MSRs to userspace Avi Kivity
2006-11-16 18:04 ` Avi Kivity
2006-11-16 19:08 ` [kvm-devel] " Arnd Bergmann
2006-11-16 19:08 ` Arnd Bergmann
2006-11-16 19:17 ` [kvm-devel] " Avi Kivity
2006-11-17 8:06 ` Christoph Hellwig
2006-11-17 8:06 ` Christoph Hellwig
2006-11-17 1:02 ` Andrew Morton
2006-11-17 7:20 ` Avi Kivity
2006-11-17 7:20 ` Avi Kivity
2006-11-17 8:15 ` Andrew Morton
2006-11-17 8:15 ` Andrew Morton
2006-11-17 8:17 ` Avi Kivity [this message]
2006-11-17 8:17 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=455D7034.1070503@qumranet.com \
--to=avi@qumranet.com \
--cc=akpm@osdl.org \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=uril@qumranet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.