All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
	mm-commits@vger.kernel.org, ak@suse.de, ashok.raj@intel.com,
	akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] genapic: always use physical delivery mode on > 8 CPUs
Date: Tue, 28 Nov 2006 11:14:15 -0800	[thread overview]
Message-ID: <20061128111414.A16460@unix-os.sc.intel.com> (raw)
In-Reply-To: <20061128063345.GA19523@elte.hu>; from mingo@elte.hu on Tue, Nov 28, 2006 at 07:33:46AM +0100

On Tue, Nov 28, 2006 at 07:33:46AM +0100, Ingo Molnar wrote:
> -	if (clusters <= 1 && max_cluster <= 8 && cluster_cnt[0] == max_cluster)
> +	if (max_apic < 8)

Patch mostly looks good.  Instead of checking for max_apic, can we use
	cpus_weight(cpu_possible_map) <= 8

This will help where initially system booted with <= 8 cpus and hotplug
potentially can bringup more cpus later..

thanks,
suresh
	
>  		genapic = &apic_flat;
>  	else
> -		genapic = &apic_cluster;
> +force_physflat:
> +		genapic = &apic_physflat;

       reply	other threads:[~2006-11-28 19:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200611140109.kAE19f5e014490@shell0.pdx.osdl.net>
     [not found] ` <20061127141849.A9978@unix-os.sc.intel.com>
     [not found]   ` <20061128063345.GA19523@elte.hu>
2006-11-28 19:14     ` Siddha, Suresh B [this message]
2006-11-28 20:23       ` [patch] genapic: default to physical mode on hotplug CPU kernels Ingo Molnar
2006-11-28 22:31         ` Siddha, Suresh B
2006-11-29  7:10           ` Ingo Molnar
2006-11-29  8:08             ` Ingo Molnar
2006-11-30  2:56               ` Siddha, Suresh B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061128111414.A16460@unix-os.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=ashok.raj@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mm-commits@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.