From: Ingo Molnar <mingo@elte.hu>
To: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: mm-commits@vger.kernel.org, ak@suse.de, ashok.raj@intel.com,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: [patch] genapic: default to physical mode on hotplug CPU kernels
Date: Tue, 28 Nov 2006 21:23:22 +0100 [thread overview]
Message-ID: <20061128202322.GA29334@elte.hu> (raw)
In-Reply-To: <20061128111414.A16460@unix-os.sc.intel.com>
* Siddha, Suresh B <suresh.b.siddha@intel.com> wrote:
> On Tue, Nov 28, 2006 at 07:33:46AM +0100, Ingo Molnar wrote:
> > - if (clusters <= 1 && max_cluster <= 8 && cluster_cnt[0] == max_cluster)
> > + if (max_apic < 8)
>
> Patch mostly looks good. Instead of checking for max_apic, can we use
> cpus_weight(cpu_possible_map) <= 8
ok - but i think it's still possible the BIOS tells us APIC IDs that are
larger than 7, even if there are fewer CPUs. So i think the patch below
should cover it. Agreed?
Ingo
-------------------->
From: Ingo Molnar <mingo@elte.hu>
Subject: [patch] genapic: default to physical mode on hotplug CPU kernels
default to physical mode on hotplug CPU kernels.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Index: linux/arch/x86_64/kernel/genapic.c
===================================================================
--- linux.orig/arch/x86_64/kernel/genapic.c
+++ linux/arch/x86_64/kernel/genapic.c
@@ -51,7 +51,7 @@ void __init clustered_apic_check(void)
max_apic = id;
}
- if (max_apic < 8)
+ if (max_apic < 8 && cpus_weight(cpu_possible_map) <= 8)
genapic = &apic_flat;
else
genapic = &apic_physflat;
next prev parent reply other threads:[~2006-11-28 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200611140109.kAE19f5e014490@shell0.pdx.osdl.net>
[not found] ` <20061127141849.A9978@unix-os.sc.intel.com>
[not found] ` <20061128063345.GA19523@elte.hu>
2006-11-28 19:14 ` [patch] genapic: always use physical delivery mode on > 8 CPUs Siddha, Suresh B
2006-11-28 20:23 ` Ingo Molnar [this message]
2006-11-28 22:31 ` [patch] genapic: default to physical mode on hotplug CPU kernels Siddha, Suresh B
2006-11-29 7:10 ` Ingo Molnar
2006-11-29 8:08 ` Ingo Molnar
2006-11-30 2:56 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061128202322.GA29334@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.