From: Matthew Wilcox <matthew@wil.cx>
To: Christoph Lameter <clameter@sgi.com>
Cc: David Howells <dhowells@redhat.com>,
torvalds@osdl.org, akpm@osdl.org,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH] WorkStruct: Implement generic UP cmpxchg() where an arch doesn't support it
Date: Wed, 6 Dec 2006 15:05:32 -0700 [thread overview]
Message-ID: <20061206220532.GF3013@parisc-linux.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0612061345160.28672@schroedinger.engr.sgi.com>
On Wed, Dec 06, 2006 at 01:52:20PM -0800, Christoph Lameter wrote:
> On Wed, 6 Dec 2006, Matthew Wilcox wrote:
>
> > And for those of us with only load-and-zero, that's simply:
> >
> > #define load_locked(addr) spin_lock(hash(addr)), *addr
> > #define store_exclusive(addr, old, new) \
> > *addr = new, spin_unlock(hash(addr)), 0
> >
> > which is also optimal for us.
>
> This means we tolerate the assignment race for SMP that was pointed out
> earlier?
What gave you that impression? It simply wasn't part of this example.
To be honest, it'd be much easier if we only defined these operations on
atomic_t's. We have all the infrastructure in place for them, and
they're fairly well understood. If you need different sizes, I'm OK
with an atomic_pointer_t, or whatever.
next prev parent reply other threads:[~2006-12-06 22:05 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-06 16:43 [PATCH] WorkStruct: Implement generic UP cmpxchg() where an arch doesn't support it David Howells
2006-12-06 17:21 ` Linus Torvalds
2006-12-06 18:56 ` Christoph Lameter
2006-12-06 19:00 ` Russell King
2006-12-06 19:16 ` Christoph Lameter
2006-12-06 19:28 ` Linus Torvalds
2006-12-06 19:58 ` Russell King
2006-12-06 21:36 ` Matthew Wilcox
2006-12-06 21:52 ` Christoph Lameter
2006-12-06 22:05 ` Matthew Wilcox [this message]
2006-12-06 22:15 ` Christoph Lameter
2006-12-07 0:37 ` Roman Zippel
2006-12-07 0:54 ` Linus Torvalds
2006-12-07 1:05 ` Roman Zippel
2006-12-07 1:18 ` Linus Torvalds
2006-12-07 1:24 ` Roman Zippel
2006-12-07 1:36 ` Linus Torvalds
2006-12-07 1:44 ` Matthew Wilcox
2006-12-07 2:09 ` Douglas McNaught
2006-12-07 1:52 ` Roman Zippel
2006-12-07 9:23 ` Nick Piggin
2006-12-06 22:38 ` Linus Torvalds
2006-12-07 9:31 ` Nick Piggin
2006-12-07 13:20 ` Ivan Kokshaysky
2006-12-07 15:03 ` Russell King
2006-12-08 1:18 ` Nick Piggin
2006-12-08 8:56 ` Russell King
2006-12-08 16:06 ` Christoph Lameter
2006-12-08 16:31 ` Russell King
2006-12-08 16:43 ` Christoph Lameter
2006-12-08 16:47 ` Russell King
2006-12-08 16:53 ` Christoph Lameter
2006-12-08 16:58 ` Russell King
2006-12-08 16:56 ` David Howells
2006-12-08 17:06 ` Christoph Lameter
2006-12-08 17:18 ` Russell King
2006-12-08 17:23 ` Christoph Lameter
2006-12-08 19:15 ` Linus Torvalds
2006-12-08 19:31 ` Russell King
2006-12-08 19:37 ` Linus Torvalds
2006-12-08 19:43 ` Russell King
2006-12-08 20:01 ` Linus Torvalds
2006-12-08 18:46 ` Linus Torvalds
2006-12-08 19:04 ` Russell King
2006-12-08 19:35 ` Linus Torvalds
2006-12-08 19:59 ` Russell King
2006-12-08 20:34 ` Linus Torvalds
2006-12-11 11:04 ` David Howells
2006-12-08 22:33 ` Nick Piggin
2006-12-07 15:36 ` Linus Torvalds
2006-12-07 16:51 ` Ralf Baechle
2006-12-07 0:46 ` Ralf Baechle
2006-12-06 19:05 ` Linus Torvalds
2006-12-06 19:08 ` Al Viro
2006-12-06 19:25 ` Linus Torvalds
2006-12-06 19:29 ` Matthew Wilcox
2006-12-06 19:43 ` David Howells
2006-12-06 19:54 ` Linus Torvalds
2006-12-06 19:56 ` Linus Torvalds
2006-12-07 1:09 ` David Miller
2006-12-06 19:26 ` Matthew Wilcox
2006-12-06 19:29 ` Christoph Lameter
2006-12-06 19:36 ` Matthew Wilcox
2006-12-06 19:47 ` Christoph Lameter
2006-12-06 19:50 ` Matthew Wilcox
2006-12-06 20:11 ` Christoph Lameter
2006-12-06 20:17 ` Matthew Wilcox
2006-12-06 19:34 ` Linus Torvalds
2006-12-06 19:41 ` Matthew Wilcox
2006-12-06 19:45 ` David Howells
2006-12-06 20:00 ` Russell King
2006-12-07 15:06 ` Russell King
2006-12-08 15:32 ` Russell King
2006-12-06 19:12 ` Lennert Buytenhek
2006-12-06 19:47 ` David Howells
2006-12-06 20:09 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061206220532.GF3013@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.