From: David Howells <dhowells@redhat.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linus Torvalds <torvalds@osdl.org>,
Al Viro <viro@ftp.linux.org.uk>,
Christoph Lameter <clameter@sgi.com>,
Russell King <rmk+lkml@arm.linux.org.uk>,
David Howells <dhowells@redhat.com>,
Andrew Morton <akpm@osdl.org>,
linux-arm-kernel@lists.arm.linux.org.uk,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH] WorkStruct: Implement generic UP cmpxchg() where an arch doesn't support it
Date: Wed, 06 Dec 2006 19:43:15 +0000 [thread overview]
Message-ID: <28576.1165434195@redhat.com> (raw)
In-Reply-To: <20061206192939.GX3013@parisc-linux.org>
Matthew Wilcox <matthew@wil.cx> wrote:
> > Ok. For SMP-safety, it's important that any architecture that can't do
> > this needs to _share_ the same spinlock (on SMP only, of course) that it
> > uses for the bitops.
>
> That doesn't help, since assignment can't be guarded by any lock.
It's not a problem for workqueues, since the only direct assignment to the
management member variable is during initialisation.
But in general cmpxchg() might be a problem with respect to assignment.
atomic_cmpxchg() should be safe wrt atomic_set().
David
next prev parent reply other threads:[~2006-12-06 19:43 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-06 16:43 [PATCH] WorkStruct: Implement generic UP cmpxchg() where an arch doesn't support it David Howells
2006-12-06 17:21 ` Linus Torvalds
2006-12-06 18:56 ` Christoph Lameter
2006-12-06 19:00 ` Russell King
2006-12-06 19:16 ` Christoph Lameter
2006-12-06 19:28 ` Linus Torvalds
2006-12-06 19:58 ` Russell King
2006-12-06 21:36 ` Matthew Wilcox
2006-12-06 21:52 ` Christoph Lameter
2006-12-06 22:05 ` Matthew Wilcox
2006-12-06 22:15 ` Christoph Lameter
2006-12-07 0:37 ` Roman Zippel
2006-12-07 0:54 ` Linus Torvalds
2006-12-07 1:05 ` Roman Zippel
2006-12-07 1:18 ` Linus Torvalds
2006-12-07 1:24 ` Roman Zippel
2006-12-07 1:36 ` Linus Torvalds
2006-12-07 1:44 ` Matthew Wilcox
2006-12-07 2:09 ` Douglas McNaught
2006-12-07 1:52 ` Roman Zippel
2006-12-07 9:23 ` Nick Piggin
2006-12-06 22:38 ` Linus Torvalds
2006-12-07 9:31 ` Nick Piggin
2006-12-07 13:20 ` Ivan Kokshaysky
2006-12-07 15:03 ` Russell King
2006-12-08 1:18 ` Nick Piggin
2006-12-08 8:56 ` Russell King
2006-12-08 16:06 ` Christoph Lameter
2006-12-08 16:31 ` Russell King
2006-12-08 16:43 ` Christoph Lameter
2006-12-08 16:47 ` Russell King
2006-12-08 16:53 ` Christoph Lameter
2006-12-08 16:58 ` Russell King
2006-12-08 16:56 ` David Howells
2006-12-08 17:06 ` Christoph Lameter
2006-12-08 17:18 ` Russell King
2006-12-08 17:23 ` Christoph Lameter
2006-12-08 19:15 ` Linus Torvalds
2006-12-08 19:31 ` Russell King
2006-12-08 19:37 ` Linus Torvalds
2006-12-08 19:43 ` Russell King
2006-12-08 20:01 ` Linus Torvalds
2006-12-08 18:46 ` Linus Torvalds
2006-12-08 19:04 ` Russell King
2006-12-08 19:35 ` Linus Torvalds
2006-12-08 19:59 ` Russell King
2006-12-08 20:34 ` Linus Torvalds
2006-12-11 11:04 ` David Howells
2006-12-08 22:33 ` Nick Piggin
2006-12-07 15:36 ` Linus Torvalds
2006-12-07 16:51 ` Ralf Baechle
2006-12-07 0:46 ` Ralf Baechle
2006-12-06 19:05 ` Linus Torvalds
2006-12-06 19:08 ` Al Viro
2006-12-06 19:25 ` Linus Torvalds
2006-12-06 19:29 ` Matthew Wilcox
2006-12-06 19:43 ` David Howells [this message]
2006-12-06 19:54 ` Linus Torvalds
2006-12-06 19:56 ` Linus Torvalds
2006-12-07 1:09 ` David Miller
2006-12-06 19:26 ` Matthew Wilcox
2006-12-06 19:29 ` Christoph Lameter
2006-12-06 19:36 ` Matthew Wilcox
2006-12-06 19:47 ` Christoph Lameter
2006-12-06 19:50 ` Matthew Wilcox
2006-12-06 20:11 ` Christoph Lameter
2006-12-06 20:17 ` Matthew Wilcox
2006-12-06 19:34 ` Linus Torvalds
2006-12-06 19:41 ` Matthew Wilcox
2006-12-06 19:45 ` David Howells
2006-12-06 20:00 ` Russell King
2006-12-07 15:06 ` Russell King
2006-12-08 15:32 ` Russell King
2006-12-06 19:12 ` Lennert Buytenhek
2006-12-06 19:47 ` David Howells
2006-12-06 20:09 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28576.1165434195@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.