From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, len.brown@intel.com
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [-mm patch] ACPI: make code static
Date: Mon, 11 Dec 2006 19:40:48 +0100 [thread overview]
Message-ID: <20061211184048.GB28443@stusta.de> (raw)
In-Reply-To: <20061211005807.f220b81c.akpm@osdl.org>
On Mon, Dec 11, 2006 at 12:58:07AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.19-rc6-mm2:
>...
> git-acpi.patch
>...
> git trees.
>...
This patch makes needlessly global code static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/acpi/bus.c | 2 +-
drivers/acpi/dock.c | 4 ++--
drivers/acpi/pci_bind.c | 4 ++--
include/acpi/acpi_bus.h | 2 --
include/acpi/acpi_drivers.h | 2 --
5 files changed, 5 insertions(+), 9 deletions(-)
--- linux-2.6.19-mm1/include/acpi/acpi_bus.h.old 2006-12-11 17:59:03.000000000 +0100
+++ linux-2.6.19-mm1/include/acpi/acpi_bus.h 2006-12-11 17:59:08.000000000 +0100
@@ -317,8 +317,6 @@
u32 data;
};
-extern struct subsystem acpi_subsys;
-
/*
* External Functions
*/
--- linux-2.6.19-mm1/drivers/acpi/bus.c.old 2006-12-11 16:44:31.000000000 +0100
+++ linux-2.6.19-mm1/drivers/acpi/bus.c 2006-12-11 16:44:56.000000000 +0100
@@ -728,7 +728,7 @@
return -ENODEV;
}
-decl_subsys(acpi, NULL, NULL);
+static decl_subsys(acpi, NULL, NULL);
static int __init acpi_init(void)
{
--- linux-2.6.19-mm1/include/acpi/acpi_drivers.h.old 2006-12-11 16:45:46.000000000 +0100
+++ linux-2.6.19-mm1/include/acpi/acpi_drivers.h 2006-12-11 16:46:09.000000000 +0100
@@ -68,8 +68,6 @@
struct pci_bus;
acpi_status acpi_get_pci_id(acpi_handle handle, struct acpi_pci_id *id);
-int acpi_pci_bind(struct acpi_device *device);
-int acpi_pci_unbind(struct acpi_device *device);
int acpi_pci_bind_root(struct acpi_device *device, struct acpi_pci_id *id,
struct pci_bus *bus);
--- linux-2.6.19-mm1/drivers/acpi/pci_bind.c.old 2006-12-11 16:46:17.000000000 +0100
+++ linux-2.6.19-mm1/drivers/acpi/pci_bind.c 2006-12-11 16:46:35.000000000 +0100
@@ -106,7 +106,7 @@
EXPORT_SYMBOL(acpi_get_pci_id);
-int acpi_pci_bind(struct acpi_device *device)
+static int acpi_pci_bind(struct acpi_device *device)
{
int result = 0;
acpi_status status = AE_OK;
@@ -265,7 +265,7 @@
return result;
}
-int acpi_pci_unbind(struct acpi_device *device)
+static int acpi_pci_unbind(struct acpi_device *device)
{
int result = 0;
acpi_status status = AE_OK;
--- linux-2.6.19-mm1/drivers/acpi/dock.c.old 2006-12-11 16:47:24.000000000 +0100
+++ linux-2.6.19-mm1/drivers/acpi/dock.c 2006-12-11 16:47:55.000000000 +0100
@@ -639,7 +639,7 @@
return snprintf(buf, PAGE_SIZE, "%d\n", dock_present(dock_station));
}
-DEVICE_ATTR(docked, S_IRUGO, show_docked, NULL);
+static DEVICE_ATTR(docked, S_IRUGO, show_docked, NULL);
/*
* write_undock - write method for "undock" file in sysfs
@@ -655,7 +655,7 @@
ret = handle_eject_request(dock_station, ACPI_NOTIFY_EJECT_REQUEST);
return ret ? ret: count;
}
-DEVICE_ATTR(undock, S_IWUSR, NULL, write_undock);
+static DEVICE_ATTR(undock, S_IWUSR, NULL, write_undock);
/**
* dock_add - add a new dock station
next prev parent reply other threads:[~2006-12-11 18:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-11 8:58 2.6.19-mm1 Andrew Morton
2006-12-11 9:18 ` 2.6.19-mm1 Nick Piggin
2006-12-11 10:41 ` 2.6.19-mm1 Jiri Kosina
2006-12-11 14:28 ` 2.6.19-mm1 Nick Piggin
2006-12-11 14:33 ` 2.6.19-mm1 Jiri Kosina
2006-12-11 15:07 ` 2.6.19-mm1 Nick Piggin
2006-12-11 16:00 ` 2.6.19-mm1 Jiri Kosina
2006-12-11 11:10 ` [Ocfs2-devel] [RFC: -mm patch] OCFS2: make code static Adrian Bunk
2006-12-11 19:10 ` Adrian Bunk
2006-12-11 14:26 ` [Ocfs2-devel] " Mark Fasheh
2006-12-11 22:26 ` Mark Fasheh
2006-12-13 15:17 ` [Ocfs2-devel] [-mm patch] fs/ocfs2/dlm/: make functions static Adrian Bunk
2006-12-13 23:17 ` Adrian Bunk
2006-12-11 14:57 ` 2.6.19-mm1: i386: unused idle notifiers added Adrian Bunk
2006-12-11 16:42 ` 2.6.19-mm1: missing MTD_UBI* help texts Adrian Bunk
2006-12-13 12:37 ` Artem Bityutskiy
2006-12-13 12:37 ` Artem Bityutskiy
2006-12-11 18:40 ` [-mm patch] make sysrq_always_enabled_setup() static Adrian Bunk
2006-12-11 19:11 ` Ingo Molnar
2006-12-11 18:40 ` Adrian Bunk [this message]
2006-12-11 19:06 ` [-mm patch] drivers/uio/: make 3 functions static Adrian Bunk
2006-12-11 20:46 ` 2.6.19-mm1: drivers/mtd/ubi/debug.c: unused variable Adrian Bunk
2006-12-12 11:53 ` Josh Boyer
2006-12-13 12:36 ` Artem Bityutskiy
2006-12-13 12:36 ` Artem Bityutskiy
2006-12-11 22:41 ` 2.6.19-mm1 Rafael J. Wysocki
2006-12-11 22:52 ` 2.6.19-mm1 (md/raid1 randomly drops partitions) Neil Brown
2006-12-11 23:43 ` Rafael J. Wysocki
2006-12-11 23:54 ` Neil Brown
2006-12-12 20:55 ` Rafael J. Wysocki
2006-12-13 0:53 ` 2.6.19-mm1 (md/raid1 randomly drops partitions - possible sata_uli problem) Neil Brown
2006-12-13 11:51 ` Rafael J. Wysocki
2006-12-12 5:53 ` 2.6.19-mm1 KAMEZAWA Hiroyuki
2006-12-12 6:06 ` 2.6.19-mm1 Andrew Morton
2006-12-12 6:43 ` 2.6.19-mm1 KAMEZAWA Hiroyuki
2006-12-12 8:04 ` 2.6.19-mm1 Andrew Morton
2006-12-13 1:17 ` 2.6.19-mm1 Conke Hu
2006-12-13 1:50 ` 2.6.19-mm1 Andrew Morton
2006-12-13 13:05 ` 2.6.19-mm1: gotemp: memset(..., 0) error Adrian Bunk
2006-12-14 23:50 ` Greg KH
2006-12-13 13:06 ` [-mm patch] slm_set_taskperm(): remove horrible error handling code Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061211184048.GB28443@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.