All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.19-mm1: gotemp: memset(..., 0) error
Date: Thu, 14 Dec 2006 15:50:59 -0800	[thread overview]
Message-ID: <20061214235059.GA11375@kroah.com> (raw)
In-Reply-To: <20061213130559.GD3851@stusta.de>

On Wed, Dec 13, 2006 at 02:05:59PM +0100, Adrian Bunk wrote:
> <--  snip  -->
> 
> ...
> NOT FOR MAINLINE!
> 
> This is for the driver tutorial I give.  It will not be included in the
> mainline kernel tree ever.  Use the ldusb driver that is already there
> instead for this device.
> 
> This is only a teaching tool.
> ...
> +       pkt = kmalloc(sizeof(*pkt), GFP_ATOMIC);
> +       if (!pkt)
> +               return -ENOMEM;
> +       memset(pkt, sizeof(*pkt), 0x00);
> ...
> 
> <--  snip  -->
> 
> 
> Lesson 1:
> Write an USB driver.
> 
> Lesson 2:
> Correct the memset() argument order or use kzalloc().

Heh, thanks, I've now fixed that up in my tree.

greg k-h

  reply	other threads:[~2006-12-14 23:51 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-11  8:58 2.6.19-mm1 Andrew Morton
2006-12-11  9:18 ` 2.6.19-mm1 Nick Piggin
2006-12-11 10:41 ` 2.6.19-mm1 Jiri Kosina
2006-12-11 14:28   ` 2.6.19-mm1 Nick Piggin
2006-12-11 14:33     ` 2.6.19-mm1 Jiri Kosina
2006-12-11 15:07       ` 2.6.19-mm1 Nick Piggin
2006-12-11 16:00         ` 2.6.19-mm1 Jiri Kosina
2006-12-11 11:10 ` [Ocfs2-devel] [RFC: -mm patch] OCFS2: make code static Adrian Bunk
2006-12-11 19:10   ` Adrian Bunk
2006-12-11 14:26   ` [Ocfs2-devel] " Mark Fasheh
2006-12-11 22:26     ` Mark Fasheh
2006-12-13 15:17     ` [Ocfs2-devel] [-mm patch] fs/ocfs2/dlm/: make functions static Adrian Bunk
2006-12-13 23:17       ` Adrian Bunk
2006-12-11 14:57 ` 2.6.19-mm1: i386: unused idle notifiers added Adrian Bunk
2006-12-11 16:42 ` 2.6.19-mm1: missing MTD_UBI* help texts Adrian Bunk
2006-12-13 12:37   ` Artem Bityutskiy
2006-12-13 12:37     ` Artem Bityutskiy
2006-12-11 18:40 ` [-mm patch] make sysrq_always_enabled_setup() static Adrian Bunk
2006-12-11 19:11   ` Ingo Molnar
2006-12-11 18:40 ` [-mm patch] ACPI: make code static Adrian Bunk
2006-12-11 19:06 ` [-mm patch] drivers/uio/: make 3 functions static Adrian Bunk
2006-12-11 20:46 ` 2.6.19-mm1: drivers/mtd/ubi/debug.c: unused variable Adrian Bunk
2006-12-12 11:53   ` Josh Boyer
2006-12-13 12:36   ` Artem Bityutskiy
2006-12-13 12:36     ` Artem Bityutskiy
2006-12-11 22:41 ` 2.6.19-mm1 Rafael J. Wysocki
2006-12-11 22:52   ` 2.6.19-mm1 (md/raid1 randomly drops partitions) Neil Brown
2006-12-11 23:43     ` Rafael J. Wysocki
2006-12-11 23:54       ` Neil Brown
2006-12-12 20:55         ` Rafael J. Wysocki
2006-12-13  0:53           ` 2.6.19-mm1 (md/raid1 randomly drops partitions - possible sata_uli problem) Neil Brown
2006-12-13 11:51             ` Rafael J. Wysocki
2006-12-12  5:53 ` 2.6.19-mm1 KAMEZAWA Hiroyuki
2006-12-12  6:06   ` 2.6.19-mm1 Andrew Morton
2006-12-12  6:43     ` 2.6.19-mm1 KAMEZAWA Hiroyuki
2006-12-12  8:04       ` 2.6.19-mm1 Andrew Morton
2006-12-13  1:17 ` 2.6.19-mm1 Conke Hu
2006-12-13  1:50   ` 2.6.19-mm1 Andrew Morton
2006-12-13 13:05 ` 2.6.19-mm1: gotemp: memset(..., 0) error Adrian Bunk
2006-12-14 23:50   ` Greg KH [this message]
2006-12-13 13:06 ` [-mm patch] slm_set_taskperm(): remove horrible error handling code Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061214235059.GA11375@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.