All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>,
	mark.fasheh@oracle.com, kurt.hackel@oracle.com
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [RFC: -mm patch] OCFS2: make code static
Date: Mon Dec 11 11:10:04 2006	[thread overview]
Message-ID: <20061211191001.GF28443@stusta.de> (raw)
In-Reply-To: <20061211005807.f220b81c.akpm@osdl.org>

On Mon, Dec 11, 2006 at 12:58:07AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.19-rc6-mm2:
>...
>  git-ocfs2.patch
>...
>  git trees.
>...

This patch makes needlessly global code static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 fs/ocfs2/cluster/tcp.c   |    2 +-
 fs/ocfs2/dlm/dlmcommon.h |    6 ------
 fs/ocfs2/dlm/dlmmaster.c |    8 +++++---
 fs/ocfs2/dlm/dlmthread.c |    3 ++-
 4 files changed, 8 insertions(+), 11 deletions(-)

--- linux-2.6.19-mm1/fs/ocfs2/cluster/tcp.c.old	2006-12-11 18:34:09.000000000 +0100
+++ linux-2.6.19-mm1/fs/ocfs2/cluster/tcp.c	2006-12-11 18:34:19.000000000 +0100
@@ -380,7 +380,7 @@
 		sc_put(sc);
 }
 
-atomic_t o2net_connected_peers = ATOMIC_INIT(0);
+static atomic_t o2net_connected_peers = ATOMIC_INIT(0);
 
 int o2net_num_connected_peers(void)
 {
--- linux-2.6.19-mm1/fs/ocfs2/dlm/dlmcommon.h.old	2006-12-11 18:34:44.000000000 +0100
+++ linux-2.6.19-mm1/fs/ocfs2/dlm/dlmcommon.h	2006-12-11 18:36:22.000000000 +0100
@@ -739,8 +739,6 @@
 			      struct dlm_lock_resource *res);
 void dlm_lockres_calc_usage(struct dlm_ctxt *dlm,
 			    struct dlm_lock_resource *res);
-int dlm_purge_lockres(struct dlm_ctxt *dlm,
-		      struct dlm_lock_resource *lockres);
 static inline void dlm_lockres_get(struct dlm_lock_resource *res)
 {
 	/* This is called on every lookup, so it might be worth
@@ -864,10 +862,6 @@
 void dlm_hb_node_down_cb(struct o2nm_node *node, int idx, void *data);
 void dlm_hb_node_up_cb(struct o2nm_node *node, int idx, void *data);
 
-int dlm_lockres_is_dirty(struct dlm_ctxt *dlm, struct dlm_lock_resource *res);
-int dlm_migrate_lockres(struct dlm_ctxt *dlm,
-			struct dlm_lock_resource *res,
-			u8 target);
 int dlm_empty_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res);
 int dlm_finish_migration(struct dlm_ctxt *dlm,
 			 struct dlm_lock_resource *res,
--- linux-2.6.19-mm1/fs/ocfs2/dlm/dlmmaster.c.old	2006-12-11 18:35:13.000000000 +0100
+++ linux-2.6.19-mm1/fs/ocfs2/dlm/dlmmaster.c	2006-12-11 18:37:28.000000000 +0100
@@ -2327,8 +2327,9 @@
  */
 
 
-int dlm_migrate_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res,
-			u8 target)
+static int dlm_migrate_lockres(struct dlm_ctxt *dlm,
+			       struct dlm_lock_resource *res,
+			       u8 target)
 {
 	struct dlm_master_list_entry *mle = NULL;
 	struct dlm_master_list_entry *oldmle = NULL;
@@ -2676,7 +2677,8 @@
 	return can_proceed;
 }
 
-int dlm_lockres_is_dirty(struct dlm_ctxt *dlm, struct dlm_lock_resource *res)
+static int dlm_lockres_is_dirty(struct dlm_ctxt *dlm,
+				struct dlm_lock_resource *res)
 {
 	int ret;
 	spin_lock(&res->spinlock);
--- linux-2.6.19-mm1/fs/ocfs2/dlm/dlmthread.c.old	2006-12-11 18:36:29.000000000 +0100
+++ linux-2.6.19-mm1/fs/ocfs2/dlm/dlmthread.c	2006-12-11 18:36:41.000000000 +0100
@@ -154,7 +154,8 @@
 	spin_unlock(&dlm->spinlock);
 }
 
-int dlm_purge_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res)
+static int dlm_purge_lockres(struct dlm_ctxt *dlm,
+			     struct dlm_lock_resource *res)
 {
 	int master;
 	int ret = 0;

WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>,
	mark.fasheh@oracle.com, kurt.hackel@oracle.com
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [RFC: -mm patch] OCFS2: make code static
Date: Mon, 11 Dec 2006 20:10:01 +0100	[thread overview]
Message-ID: <20061211191001.GF28443@stusta.de> (raw)
In-Reply-To: <20061211005807.f220b81c.akpm@osdl.org>

On Mon, Dec 11, 2006 at 12:58:07AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.19-rc6-mm2:
>...
>  git-ocfs2.patch
>...
>  git trees.
>...

This patch makes needlessly global code static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 fs/ocfs2/cluster/tcp.c   |    2 +-
 fs/ocfs2/dlm/dlmcommon.h |    6 ------
 fs/ocfs2/dlm/dlmmaster.c |    8 +++++---
 fs/ocfs2/dlm/dlmthread.c |    3 ++-
 4 files changed, 8 insertions(+), 11 deletions(-)

--- linux-2.6.19-mm1/fs/ocfs2/cluster/tcp.c.old	2006-12-11 18:34:09.000000000 +0100
+++ linux-2.6.19-mm1/fs/ocfs2/cluster/tcp.c	2006-12-11 18:34:19.000000000 +0100
@@ -380,7 +380,7 @@
 		sc_put(sc);
 }
 
-atomic_t o2net_connected_peers = ATOMIC_INIT(0);
+static atomic_t o2net_connected_peers = ATOMIC_INIT(0);
 
 int o2net_num_connected_peers(void)
 {
--- linux-2.6.19-mm1/fs/ocfs2/dlm/dlmcommon.h.old	2006-12-11 18:34:44.000000000 +0100
+++ linux-2.6.19-mm1/fs/ocfs2/dlm/dlmcommon.h	2006-12-11 18:36:22.000000000 +0100
@@ -739,8 +739,6 @@
 			      struct dlm_lock_resource *res);
 void dlm_lockres_calc_usage(struct dlm_ctxt *dlm,
 			    struct dlm_lock_resource *res);
-int dlm_purge_lockres(struct dlm_ctxt *dlm,
-		      struct dlm_lock_resource *lockres);
 static inline void dlm_lockres_get(struct dlm_lock_resource *res)
 {
 	/* This is called on every lookup, so it might be worth
@@ -864,10 +862,6 @@
 void dlm_hb_node_down_cb(struct o2nm_node *node, int idx, void *data);
 void dlm_hb_node_up_cb(struct o2nm_node *node, int idx, void *data);
 
-int dlm_lockres_is_dirty(struct dlm_ctxt *dlm, struct dlm_lock_resource *res);
-int dlm_migrate_lockres(struct dlm_ctxt *dlm,
-			struct dlm_lock_resource *res,
-			u8 target);
 int dlm_empty_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res);
 int dlm_finish_migration(struct dlm_ctxt *dlm,
 			 struct dlm_lock_resource *res,
--- linux-2.6.19-mm1/fs/ocfs2/dlm/dlmmaster.c.old	2006-12-11 18:35:13.000000000 +0100
+++ linux-2.6.19-mm1/fs/ocfs2/dlm/dlmmaster.c	2006-12-11 18:37:28.000000000 +0100
@@ -2327,8 +2327,9 @@
  */
 
 
-int dlm_migrate_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res,
-			u8 target)
+static int dlm_migrate_lockres(struct dlm_ctxt *dlm,
+			       struct dlm_lock_resource *res,
+			       u8 target)
 {
 	struct dlm_master_list_entry *mle = NULL;
 	struct dlm_master_list_entry *oldmle = NULL;
@@ -2676,7 +2677,8 @@
 	return can_proceed;
 }
 
-int dlm_lockres_is_dirty(struct dlm_ctxt *dlm, struct dlm_lock_resource *res)
+static int dlm_lockres_is_dirty(struct dlm_ctxt *dlm,
+				struct dlm_lock_resource *res)
 {
 	int ret;
 	spin_lock(&res->spinlock);
--- linux-2.6.19-mm1/fs/ocfs2/dlm/dlmthread.c.old	2006-12-11 18:36:29.000000000 +0100
+++ linux-2.6.19-mm1/fs/ocfs2/dlm/dlmthread.c	2006-12-11 18:36:41.000000000 +0100
@@ -154,7 +154,8 @@
 	spin_unlock(&dlm->spinlock);
 }
 
-int dlm_purge_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res)
+static int dlm_purge_lockres(struct dlm_ctxt *dlm,
+			     struct dlm_lock_resource *res)
 {
 	int master;
 	int ret = 0;


  parent reply	other threads:[~2006-12-11 11:10 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-11  8:58 2.6.19-mm1 Andrew Morton
2006-12-11  9:18 ` 2.6.19-mm1 Nick Piggin
2006-12-11 10:41 ` 2.6.19-mm1 Jiri Kosina
2006-12-11 14:28   ` 2.6.19-mm1 Nick Piggin
2006-12-11 14:33     ` 2.6.19-mm1 Jiri Kosina
2006-12-11 15:07       ` 2.6.19-mm1 Nick Piggin
2006-12-11 16:00         ` 2.6.19-mm1 Jiri Kosina
2006-12-11 11:10 ` Adrian Bunk [this message]
2006-12-11 19:10   ` [RFC: -mm patch] OCFS2: make code static Adrian Bunk
2006-12-11 14:26   ` [Ocfs2-devel] " Mark Fasheh
2006-12-11 22:26     ` Mark Fasheh
2006-12-13 15:17     ` [Ocfs2-devel] [-mm patch] fs/ocfs2/dlm/: make functions static Adrian Bunk
2006-12-13 23:17       ` Adrian Bunk
2006-12-11 14:57 ` 2.6.19-mm1: i386: unused idle notifiers added Adrian Bunk
2006-12-11 16:42 ` 2.6.19-mm1: missing MTD_UBI* help texts Adrian Bunk
2006-12-13 12:37   ` Artem Bityutskiy
2006-12-13 12:37     ` Artem Bityutskiy
2006-12-11 18:40 ` [-mm patch] make sysrq_always_enabled_setup() static Adrian Bunk
2006-12-11 19:11   ` Ingo Molnar
2006-12-11 18:40 ` [-mm patch] ACPI: make code static Adrian Bunk
2006-12-11 19:06 ` [-mm patch] drivers/uio/: make 3 functions static Adrian Bunk
2006-12-11 20:46 ` 2.6.19-mm1: drivers/mtd/ubi/debug.c: unused variable Adrian Bunk
2006-12-12 11:53   ` Josh Boyer
2006-12-13 12:36   ` Artem Bityutskiy
2006-12-13 12:36     ` Artem Bityutskiy
2006-12-11 22:41 ` 2.6.19-mm1 Rafael J. Wysocki
2006-12-11 22:52   ` 2.6.19-mm1 (md/raid1 randomly drops partitions) Neil Brown
2006-12-11 23:43     ` Rafael J. Wysocki
2006-12-11 23:54       ` Neil Brown
2006-12-12 20:55         ` Rafael J. Wysocki
2006-12-13  0:53           ` 2.6.19-mm1 (md/raid1 randomly drops partitions - possible sata_uli problem) Neil Brown
2006-12-13 11:51             ` Rafael J. Wysocki
2006-12-12  5:53 ` 2.6.19-mm1 KAMEZAWA Hiroyuki
2006-12-12  6:06   ` 2.6.19-mm1 Andrew Morton
2006-12-12  6:43     ` 2.6.19-mm1 KAMEZAWA Hiroyuki
2006-12-12  8:04       ` 2.6.19-mm1 Andrew Morton
2006-12-13  1:17 ` 2.6.19-mm1 Conke Hu
2006-12-13  1:50   ` 2.6.19-mm1 Andrew Morton
2006-12-13 13:05 ` 2.6.19-mm1: gotemp: memset(..., 0) error Adrian Bunk
2006-12-14 23:50   ` Greg KH
2006-12-13 13:06 ` [-mm patch] slm_set_taskperm(): remove horrible error handling code Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061211191001.GF28443@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=kurt.hackel@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.fasheh@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.